From: Wolfram Sang <wsa-dev@sang-engineering.com>
To: Jason Gerecke <killertofu@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
LKML <linux-kernel@vger.kernel.org>,
Ping Cheng <pinglinux@gmail.com>,
"Tobita, Tatsunosuke" <tatsunosuke.tobita@wacom.com>,
Jason Gerecke <jason.gerecke@wacom.com>,
Ping Cheng <ping.cheng@wacom.com>
Subject: Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls
Date: Wed, 19 Oct 2022 22:11:28 +0200 [thread overview]
Message-ID: <Y1BZ8CjSnrKi+Yos@shikoro> (raw)
In-Reply-To: <CANRwn3TutF6skHQHk08dFUa8gLMVGxui_QN7YK6nDacSpRHtLg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
> > I believe you need to create a coccinelle script and run it over the
> > kernel source tree and then create a patch out of it.
>
> This would definitely be necessary to unify all callers to using
> unsigned variables rather than just swapping which callers generate
> the pointer-sign warnings.
I am all for using u8 because this is the proper type.
Yet, if we touch this function argument, I'd also like to remove all
inconsistencies once and for all. Removing some warnings here and add
some there is not a good choice IMO. However, how to do this switch of
types cleanly without too much churn, I sadly have no good idea yet.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-19 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 15:34 [PATCH] i2c: Use u8 type in i2c transfer calls Jason Gerecke
2022-08-03 14:59 ` [PATCH v2] " Jason Gerecke
2022-08-03 16:46 ` Andy Shevchenko
2022-08-03 18:06 ` Jason Gerecke
2022-10-19 20:11 ` Wolfram Sang [this message]
2022-10-19 20:48 ` Jason Gerecke
2022-10-19 21:37 ` Wolfram Sang
2022-10-20 10:35 ` Jonathan Cameron
2022-08-06 14:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1BZ8CjSnrKi+Yos@shikoro \
--to=wsa-dev@sang-engineering.com \
--cc=andy.shevchenko@gmail.com \
--cc=jason.gerecke@wacom.com \
--cc=jic23@kernel.org \
--cc=killertofu@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
--cc=pinglinux@gmail.com \
--cc=tatsunosuke.tobita@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox