From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C6CC43217 for ; Thu, 17 Nov 2022 08:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234663AbiKQIrT (ORCPT ); Thu, 17 Nov 2022 03:47:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbiKQIrS (ORCPT ); Thu, 17 Nov 2022 03:47:18 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7D5EC03; Thu, 17 Nov 2022 00:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668674837; x=1700210837; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=6KcOzwaOfZlcBiEgPlkMskn+edpOXlDZLDpkAd0fjXc=; b=jzToVI4f2obVUayC0aujcHnqG/rt5vJavfaAul9tf30fUNNTKbSiXCCp JMtlkdTDGMWUkIT2mxTtGIIAo9O1qaEovY82IHM1y5KU+it09byjYJd7J RZADYYJQoIsnRYYXR9TV3VZRn7oToFdybUbfUwVFAbwdTuK9xZMOmLeHe 32X1CZ/wsR0tkrP2dpNK9lupO+vNr0EVjjn+tPnIdDVdt04UNypyeEx19 L8zZ4PbENfizOiXx7dh2vadzUqoUCca2Gv9abn1F+FaDhlOB5o0cy4Klp dPz9xnsU7QOdtsjjkrdYxcwfJ+c9BxIndqn8UIAIWXB6N5S2st+vZIPDv A==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="292502752" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="292502752" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 00:47:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="703245803" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="703245803" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 17 Nov 2022 00:47:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ovaYA-00DV7I-2Q; Thu, 17 Nov 2022 10:47:10 +0200 Date: Thu, 17 Nov 2022 10:47:10 +0200 From: Andy Shevchenko To: Wolfram Sang , Yinbo Zhu , Rob Herring , Krzysztof Kozlowski , Florian Fainelli , Jarkko Nikula , Jean Delvare , William Zhang , Conor Dooley , Jan Dabros , Tharun Kumar P , Phil Edworthy , Sam Protsenko , Tyrone Ting , Philipp Zabel , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller Message-ID: References: <20221117075938.23379-1-zhuyinbo@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Nov 17, 2022 at 09:35:31AM +0100, Wolfram Sang wrote: > > > Can you split slave part as a separate change? It will help to review and > > to understand the code better in the future by browsing the history. > > Thanks for all your reviewing help, Andy! Regarding this comment, I > don't think a split is needed. The driver is small enough with ~500 > lines, so I think it can stay this way. It would be different if the > driver was 1000+ lines, then I'd totally agree. I will have a look at > this driver soon. Depends on the ratio "Comments per LoC" by the certain reviewer. My experience with the other drivers for this architecture / platform that they all need much more work before accepting them. And to reduce burden split would be good. But then it's up to you (to me it's a burden for even these 500 LoCs, that are full of room to improvement). -- With Best Regards, Andy Shevchenko