From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC851C433FE for ; Sat, 19 Nov 2022 17:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234060AbiKSReO (ORCPT ); Sat, 19 Nov 2022 12:34:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234843AbiKSRdl (ORCPT ); Sat, 19 Nov 2022 12:33:41 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B3517895; Sat, 19 Nov 2022 09:33:39 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4735E749; Sat, 19 Nov 2022 18:33:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879218; bh=qb+DtyPGnqHLki0PE911QgLlJ2I1/jXnP9YLT5h0d+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OruFA3N18YfSqufN1EupAaMCLQtDFW0qAnRBQknY02WwUmC0Hqnt9DGFDo30o8qee 6aHBDro/53DI+2tMH0mtLQu8DXcSKmCVG1w+0TWaY7CbAYqYBS01K1GY0uIMyyPbnO 0V7htj6hMF/f/jB4TYInP5o9z22MY4vZe73mRvv4= Date: Sat, 19 Nov 2022 19:33:22 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 033/606] drm/bridge: tc358768: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-34-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-34-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Nov 18, 2022 at 11:36:07PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/tc358768.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c > index 4c4b77ce8aba..839b8832b9b5 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -1018,8 +1018,7 @@ static int tc358768_get_regulators(struct tc358768_priv *priv) > return ret; > } > > -static int tc358768_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int tc358768_i2c_probe(struct i2c_client *client) > { > struct tc358768_priv *priv; > struct device *dev = &client->dev; > @@ -1085,7 +1084,7 @@ static struct i2c_driver tc358768_driver = { > .of_match_table = tc358768_of_ids, > }, > .id_table = tc358768_i2c_ids, > - .probe = tc358768_i2c_probe, > + .probe_new = tc358768_i2c_probe, > .remove = tc358768_i2c_remove, > }; > module_i2c_driver(tc358768_driver); > -- > 2.38.1 > -- Regards, Laurent Pinchart