From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD04C433FE for ; Sat, 19 Nov 2022 17:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234179AbiKSRfB (ORCPT ); Sat, 19 Nov 2022 12:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235192AbiKSRej (ORCPT ); Sat, 19 Nov 2022 12:34:39 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EC1C29; Sat, 19 Nov 2022 09:34:37 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E2B71749; Sat, 19 Nov 2022 18:34:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879276; bh=00f5eVhJt99Pw1DKlvCUegQOUshzgfx+1nNmj7RLqys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NmEWjl3fD54fFlPMK5WWxrya5y6DenxeYxIkevTT6x9BdAMFaF6OT6ONNH2UT90MM GAXfyNDe9CAJsJKwla9KiczQqlHdOkWFpaeggwy89B/SA2HSjTNY2gjqnwJ0snX5uC qqxPgPWinJ91d60W9pzSuycweL4+z8FfgIicZNYw= Date: Sat, 19 Nov 2022 19:34:20 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-29-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-29-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Nov 18, 2022 at 11:36:02PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/parade-ps8622.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c > index 309de802863d..530ee6a19e7e 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8622.c > +++ b/drivers/gpu/drm/bridge/parade-ps8622.c > @@ -442,9 +442,9 @@ static const struct of_device_id ps8622_devices[] = { > }; > MODULE_DEVICE_TABLE(of, ps8622_devices); > > -static int ps8622_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int ps8622_probe(struct i2c_client *client) > { > + const struct i2c_device_id *id = i2c_client_get_device_id(client); > struct device *dev = &client->dev; > struct ps8622_bridge *ps8622; > struct drm_bridge *panel_bridge; > @@ -538,7 +538,7 @@ MODULE_DEVICE_TABLE(i2c, ps8622_i2c_table); > > static struct i2c_driver ps8622_driver = { > .id_table = ps8622_i2c_table, > - .probe = ps8622_probe, > + .probe_new = ps8622_probe, > .remove = ps8622_remove, > .driver = { > .name = "ps8622", > -- > 2.38.1 > -- Regards, Laurent Pinchart