From: Wolfram Sang <wsa@kernel.org>
To: Hui Tang <tanghui20@huawei.com>
Cc: linux-i2c@vger.kernel.org, linux@roeck-us.net,
bence98@sch.bme.hu, linux-kernel@vger.kernel.org,
weiyongjun1@huawei.com, yusongping@huawei.com
Subject: Re: [PATCH] i2c-pxa2xx: fix missing pci_disable_device() on error in ce4100_i2c_probe
Date: Mon, 5 Dec 2022 11:01:48 +0100 [thread overview]
Message-ID: <Y43BjGqsk+u/Nb+C@ninjato> (raw)
In-Reply-To: <20221114092540.247891-1-tanghui20@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Mon, Nov 14, 2022 at 05:25:40PM +0800, Hui Tang wrote:
> Using pcim_enable_device() to avoid missing pci_disable_device().
>
> Fixes: 7e94dd154e934 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")
> Signed-off-by: Hui Tang <tanghui20@huawei.com>
Fixed the subject to "i2c: pxa-pci:" and fixed this checkpatch warning:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 7e94dd154e93 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")'
#3:
Fixes: 7e94dd154e934 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")
Please do that in the future. After all that, applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-12-05 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:25 [PATCH] i2c-pxa2xx: fix missing pci_disable_device() on error in ce4100_i2c_probe Hui Tang
2022-12-05 10:01 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y43BjGqsk+u/Nb+C@ninjato \
--to=wsa@kernel.org \
--cc=bence98@sch.bme.hu \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tanghui20@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox