From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268B3C4321E for ; Fri, 25 Nov 2022 10:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbiKYKXs (ORCPT ); Fri, 25 Nov 2022 05:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230082AbiKYKXr (ORCPT ); Fri, 25 Nov 2022 05:23:47 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AB3D419A0; Fri, 25 Nov 2022 02:23:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669371826; x=1700907826; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qaiiZneNmh9uPlFJaZlbiTDiqB5tAEB90ztrbXmYIrQ=; b=O1XLGpBZa44pwJJ3TF7t/Ur/KNOTC4HMw+4H4r2Gq6CuTgZTtYEnnWNg Ao63KAJm6D63zU9btfQtpJtL+7G8r+XzCo3yHN/8r888+R/hDB5Ot2nrU MizUCZfpw1T7DTZMtSIyEgLv4N98mgVfu5i3uG53n3y/fReM8OGZLlOve YsgYoDEhqkZ3GdJSrINQP0sl3B8dyHXC5oOyMDKDqOY57STYt4t4y1DBc GVwNWUK6aQ1Xa6OjH6QtixERfvIMaPilUws0DNLisLgjx+uUbAvIVtRKJ Akse5zXf47lgHpB5NC+7kGCQkvGm8z7AprGzkazxr7KwRnvIz8o6bPtqa g==; X-IronPort-AV: E=McAfee;i="6500,9779,10541"; a="315613302" X-IronPort-AV: E=Sophos;i="5.96,193,1665471600"; d="scan'208";a="315613302" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2022 02:23:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10541"; a="636535062" X-IronPort-AV: E=Sophos;i="5.96,193,1665471600"; d="scan'208";a="636535062" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 25 Nov 2022 02:23:42 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oyVrw-00HBbq-2Q; Fri, 25 Nov 2022 12:23:40 +0200 Date: Fri, 25 Nov 2022 12:23:40 +0200 From: Andy Shevchenko To: Binbin Zhou Cc: Wolfram Sang , Wolfram Sang , Mika Westerberg , linux-i2c@vger.kernel.org, loongarch@lists.linux.dev, devicetree@vger.kernel.org, Huacai Chen , WANG Xuerui , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Jianmin Lv Subject: Re: [PATCH V3 2/5] i2c: gpio: Add support on ACPI-based system Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Nov 25, 2022 at 04:54:12PM +0800, Binbin Zhou wrote: > Add support for the ACPI-based device registration, so that the driver > can be also enabled through ACPI table. ... > +/* get i2c-gpio props from DT or ACPI table */ Get ... > - if (np) { > - of_i2c_gpio_get_props(np, pdata); > + if (np || has_acpi_companion(dev)) { > + i2c_gpio_get_props(dev, pdata); if (dev_fwnode() { i2c_gpio_get_props(dev, pdata); ... > + {"LOON0005", 0}, /*LoongArch*/ ", 0" part is redundant. Also missing spaces in the comment. -- With Best Regards, Andy Shevchenko