From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94947C3A5A7 for ; Thu, 8 Dec 2022 12:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbiLHM07 (ORCPT ); Thu, 8 Dec 2022 07:26:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbiLHM06 (ORCPT ); Thu, 8 Dec 2022 07:26:58 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 988A98658A; Thu, 8 Dec 2022 04:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670502417; x=1702038417; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=spdlWevniBpu51g03nRTe2+ZbrLpWs90S14TUiE7A/M=; b=BfdCLZOca8PNTJTb2V5gKTLkEhylw7PigXyhzUkvbIr8FWZKHtuqZzUv HumHlDAC02rVFjnF/7qbfBnp5Wtr5+1pRyE3kwDBzUB1wGyc/dVelQaOC XNq8LHAGUTTRvkXmOiGKJHu+AeJhK7WZXBJRhl7GKldG3cNyB2TTEvc42 /Dc7vwoGikd2D/jqj6/AOlchLVoNEVc8rXspBjF0dz3z6MV8og/SWgCQ2 BgL8rz+lK0+WVQpdVN0F4EjdAdSllXaGDhyqlMvvFiadwCQRoHwzM8XAb V8b3xJXsMND0I4UeRiEsNDbMZOl1AZoXuCJkEtd2YqXl0vt8b9gbYTSbM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="318297842" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="318297842" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 04:26:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="821320560" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="821320560" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 08 Dec 2022 04:26:50 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p3FzD-006KFQ-1i; Thu, 08 Dec 2022 14:26:47 +0200 Date: Thu, 8 Dec 2022 14:26:47 +0200 From: Andy Shevchenko To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Luca Ceresoli , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Laurent Pinchart , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut Subject: Re: [PATCH v5 0/8] i2c-atr and FPDLink Message-ID: References: <20221208104006.316606-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Dec 08, 2022 at 12:42:13PM +0200, Tomi Valkeinen wrote: > On 08/12/2022 12:39, Tomi Valkeinen wrote: ... > +#include > #include > #include > #include > #include > #include > -#include > #include + Blank line here? > +#define ATR_MAX_ADAPTERS 99 /* Just a sanity limit */ > +#define ATR_MAX_SYMLINK_LEN 16 /* Longest name is 10 chars: "channel-99" */ ... > + u16 *new_buf; > + > + new_buf = kmalloc_array(num, sizeof(chan->orig_addrs[0]), > + GFP_KERNEL); new_buf = kmalloc_array(num, sizeof(*new_buf), GFP_KERNEL); ? > + if (!new_buf) > return -ENOMEM; ... > struct i2c_atr_cli2alias_pair *c2a; > - u16 alias_id = 0; > - int ret = 0; > + u16 alias_id; > + int ret; Is it mangled or it's missing blank line here? > c2a = kzalloc(sizeof(*c2a), GFP_KERNEL); > if (!c2a) ... > struct device; > struct i2c_atr; > +struct fwnode_handle; Order? ... > /** > - * Helper to add I2C ATR features to a device driver. > + * struct i2c_atr - Represents the I2C ATR instance > */ This is incomplete. Have you run kernel doc validator against this file? > struct i2c_atr { > }; -- With Best Regards, Andy Shevchenko