From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
jsd@semihalf.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, benh@amazon.com,
ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, farbere@amazon.com, itamark@amazon.com,
lareine@amazon.com
Subject: Re: [PATCH 1/1] i2c: designware: use u64 for clock freq to avoid u32 multiplication overflow
Date: Wed, 14 Dec 2022 13:44:46 +0200 [thread overview]
Message-ID: <Y5m3Lh0wte/HN9NH@smile.fi.intel.com> (raw)
In-Reply-To: <20221214103418.64431-1-hhhawa@amazon.com>
On Wed, Dec 14, 2022 at 10:34:18AM +0000, Hanna Hawa wrote:
> From: Lareine Khawaly <lareine@amazon.com>
>
> In functions i2c_dw_scl_lcnt() and i2c_dw_scl_hcnt() may have overflow
> by depending on the values of the given parameters including the ic_clk.
> For example in our usecase where ic_clk >= 1000000, multiplication of
It's hard to count 0:s, can you use plain words instead (like million, billion)?
> ic_clk * 4700 will result in 32 bit overflow.
> This commit change the ic_clk to be u64 parameter to avoid the overflow.
Read Submitting Patches about imperative mood in the commit messages.
...
Smells like you are missing the Fixes tag.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-14 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 10:34 [PATCH 1/1] i2c: designware: use u64 for clock freq to avoid u32 multiplication overflow Hanna Hawa
2022-12-14 11:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5m3Lh0wte/HN9NH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonnyc@amazon.com \
--cc=jsd@semihalf.com \
--cc=lareine@amazon.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox