From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB4BC54EBD for ; Sun, 8 Jan 2023 03:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232712AbjAHDP2 (ORCPT ); Sat, 7 Jan 2023 22:15:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjAHDP1 (ORCPT ); Sat, 7 Jan 2023 22:15:27 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC88712ABD; Sat, 7 Jan 2023 19:15:26 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 99A716CF; Sun, 8 Jan 2023 04:15:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673147724; bh=76EmIUKiVHu07r5F3HCjVWZcCLgZ89B55pT9IvNWmA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ejJaP9ZUVdVix89X0X8ewvGWgwAsG0kHyiSSpasgbfj9Tzo2/amdZJlJDaaAreAGn aHdUzyYoKUpy7j18kTIpegVqnoibSBfUoi5l8XDj24qokapsQdwsFmOICxNXlngJQM /bR41GILPnoqsj1Gb/vfALe42cxbHG5ITwrsv86o= Date: Sun, 8 Jan 2023 05:15:20 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Luca Ceresoli , Andy Shevchenko , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut Subject: Re: [PATCH v6 3/8] dt-bindings: media: add TI DS90UB913 FPD-Link III Serializer Message-ID: References: <20230105140307.272052-1-tomi.valkeinen@ideasonboard.com> <20230105140307.272052-4-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230105140307.272052-4-tomi.valkeinen@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Jan 05, 2023 at 04:03:02PM +0200, Tomi Valkeinen wrote: > Add DT bindings for TI DS90UB913 FPD-Link III Serializer. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > .../bindings/media/i2c/ti,ds90ub913.yaml | 133 ++++++++++++++++++ > 1 file changed, 133 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml > new file mode 100644 > index 000000000000..f6612bb0f667 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml > @@ -0,0 +1,133 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub913.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments DS90UB913 FPD-Link III Serializer > + > +maintainers: > + - Tomi Valkeinen > + > +description: > + The TI DS90UB913 is an FPD-Link III video serializer for parallel video. > + > +properties: > + compatible: > + enum: > + - ti,ds90ub913a-q1 > + > + '#gpio-cells': > + const: 2 > + description: > + First cell is the GPO pin number, second cell is the flags. The GPO pin > + number must be in range of [0, 3]. Note that GPOs 2 and 3 are not > + available in external oscillator mode. > + > + gpio-controller: true > + > + clocks: > + maxItems: 1 > + description: > + Reference clock connected to the CLKIN pin. > + > + clock-names: > + items: > + - const: clkin > + > + '#clock-cells': > + const: 0 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Parallel input port > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + required: > + - pclk-sample > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false > + description: FPD-Link III output port > + > + required: > + - port@0 > + - port@1 > + > + i2c: > + $ref: /schemas/i2c/i2c-controller.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - '#gpio-cells' > + - gpio-controller > + - '#clock-cells' > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + serializer { > + compatible = "ti,ds90ub913a-q1"; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + clocks = <&clk_cam_48M>; > + clock-names = "clkin"; > + > + #clock-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + ub913_in: endpoint { > + remote-endpoint = <&sensor_out>; > + pclk-sample = <1>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&deser_fpd_in>; > + }; > + }; > + }; > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensor@48 { > + compatible = "aptina,mt9v111"; > + reg = <0x48>; > + > + clocks = <&fixed_clock>; > + > + port { > + sensor_out: endpoint { > + remote-endpoint = <&ub913_in>; > + }; > + }; > + }; > + }; > + }; > +... -- Regards, Laurent Pinchart