From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3] i2c: designware: add a new bit check for IC_CON control
Date: Tue, 24 Jan 2023 13:12:25 +0200 [thread overview]
Message-ID: <Y8+9GUwyl1UO6reY@smile.fi.intel.com> (raw)
In-Reply-To: <a0d42cac-b39a-f59c-950f-94bcb660472a@amd.com>
On Tue, Jan 24, 2023 at 04:03:55PM +0530, Shyam Sundar S K wrote:
> On 1/24/2023 3:59 PM, Andy Shevchenko wrote:
> > On Tue, Jan 24, 2023 at 12:27:37PM +0200, Andy Shevchenko wrote:
> >> On Tue, Jan 24, 2023 at 03:36:50PM +0530, Shyam Sundar S K wrote:
...
> >>> + u32 ic_con;
> >
> > One more nit-pick:
> >
> > unsigned int ic_con;
>
> is u32 not typedef of unsigned int?
You should not care about implementation details. You call an API that uses
unsigned int, why not using the correct type from the beginning?
> > to be same as regmap_read() uses.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-01-24 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 10:06 [PATCH v3] i2c: designware: add a new bit check for IC_CON control Shyam Sundar S K
2023-01-24 10:27 ` Andy Shevchenko
2023-01-24 10:29 ` Andy Shevchenko
[not found] ` <a0d42cac-b39a-f59c-950f-94bcb660472a@amd.com>
2023-01-24 11:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8+9GUwyl1UO6reY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox