Re: [PATCH 02/22] usb: remove the dead USB_OHCI_SH option

Geert Uytterhoeven
2023-01-13T08:59:25Z

Hi Christoph,

On Fri, Jan 13, 2023 at 7:23 AM Christoph Hellwig <hch@lst.de> wrote:
> USB_OHCI_SH is a dummy option that never builds any code, remove it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks for your patch!
Nice catch!

> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -548,17 +548,6 @@ config USB_OHCI_HCD_SSB
>
> If unsure, say N.
>
> -config USB_OHCI_SH
> - bool "OHCI support for SuperH USB controller (DEPRECATED)"
> - depends on SUPERH || COMPILE_TEST
> - select USB_OHCI_HCD_PLATFORM
> - help
> - This option is deprecated now and the driver was removed, use
> - USB_OHCI_HCD_PLATFORM instead.
> -
> - Enables support for the on-chip OHCI controller on the SuperH.
> - If you use the PCI OHCI controller, this option is not necessary.
> -

At this point in the series, there are still selects and enablements of
USB_OHCI_SH in arch/sh/Kconfig and arch/sh/configs/sh7757lcr_defconfig.
I think it would be good to replace them by USB_OHCI_HCD_PLATFORM first,
to decouple the fate of this patch from the rest of the series.

> config USB_OHCI_EXYNOS
> tristate "OHCI support for Samsung S5P/Exynos SoC Series"
> depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds