From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9454C63797 for ; Mon, 16 Jan 2023 21:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232314AbjAPV7s (ORCPT ); Mon, 16 Jan 2023 16:59:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234917AbjAPV7r (ORCPT ); Mon, 16 Jan 2023 16:59:47 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A99224491; Mon, 16 Jan 2023 13:59:47 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A2B191EC0441; Mon, 16 Jan 2023 22:59:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673906385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QHdyDsRmGsHeS5gc+1aFuObgPFEvnjm6n7kVGQTzBBE=; b=k8hpX5ws7B1G6075stAlrwc7tYOcUL2lIRbqWzoWbapv3r77i4GuEYrx2wy/3FJQeuzC/E g+7/9VAMRE9svrwVjNHFHeix2wWojRDdJS84wok+/rMoLsWufOgQqNQoEEaffm9op6O7rk i1tu52UWSRinzeRIEWUPqP/c2Mq/d04= Date: Mon, 16 Jan 2023 22:59:41 +0100 From: Borislav Petkov To: Jan =?utf-8?B?RMSFYnJvxZs=?= , "Limonciello, Mario" Cc: Hans de Goede , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com, wsa@kernel.org, rrangel@chromium.org, upstream@semihalf.com, Muralidhara M K , Naveen Krishna Chatradhi , Yazen Ghannam Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Message-ID: References: <33d5cc27-474b-fdec-a6b0-84ac16f7d386@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Jan 16, 2023 at 11:19:00AM +0100, Jan Dąbroś wrote: > It's not enough for running init_amd_nbs() to have only > pci_arch_init() done. We need the pci bus to be created and registered > with all devices found on the bus. And when is that done and ready? pci_scan_bus()? Lemme see if I understand the ordering correctly: 1. PCI needs to be initialized and all devices on the bus registered 2. AMD NB needs to run and enumerate the NBs so that the SMN access which you need, can work. 3. acpi_scan_init() 4. i2c-designware-platdrv registration Close? Now, Mario, remind me again, pls, why can't they use the MSR to get the PSP MMIO base. It has changed but why? Maybe we should talk offlist first. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette