From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C16DC433DB for ; Thu, 18 Feb 2021 12:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4052F64E79 for ; Thu, 18 Feb 2021 12:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232224AbhBRMCG (ORCPT ); Thu, 18 Feb 2021 07:02:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:52238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhBRJ4L (ORCPT ); Thu, 18 Feb 2021 04:56:11 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 672C164E5F; Thu, 18 Feb 2021 09:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613641509; bh=79ud9I3C1NXf24LTqgmPVqa9DlP867/mwk9GqbIsBWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OHxCe9GbyDb2Xkc7uYS/NLXxG7VsJ7PUBkvez2yuO4q/tdddGR1riXO1FdBcJ92+y r4GCcyjuYNJCq+nomPFHkaZakFSMHogW2fCVnVGsOAPbHRrdOA15WpvBqdk32xpoJ1 zhHQL5V89k+gLPNAK3ghz9Snu1KpIrYvQ+Nf0+vIrvkbkmQRNHDdjZGRXV4c4kgwv4 6GVxc9I9vTS2nJCaCZjG46FbU+NrLuasAyiFyOjeQSvi4arOI28tdU0QgKueFp7c21 /8gdwQtMI8WKIibpApVHQZyhu8qCz3O/9KD3YiA4ys9zzeoD2gqXKmA1hhlGtRLg8c 9qsEQE04K6z2Q== Date: Thu, 18 Feb 2021 10:45:05 +0100 From: Robert Richter To: Dejin Zheng Cc: wsa+renesas@sang-engineering.com, jan.glauber@gmail.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: thunderx: Fix an issue about missing call to 'pci_free_irq_vectors()' Message-ID: References: <20210214143734.591789-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210214143734.591789-1-zhengdejin5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 14.02.21 22:37:34, Dejin Zheng wrote: > Call to 'pci_free_irq_vectors()' are missing both in the error handling > path of the probe function, and in the remove function. So add them. > > Fixes: 4c21541d8da17fb ("i2c: thunderx: Replace pci_enable_msix()") > Signed-off-by: Dejin Zheng > --- > drivers/i2c/busses/i2c-thunderx-pcidrv.c | 9 ++++++--- FTR, I reviewed the error paths of thunder_i2c_probe_pci() (v5.11-rc1) and all look sane to me. -Robert