From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92016C433DB for ; Mon, 15 Feb 2021 13:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64CDE60C3E for ; Mon, 15 Feb 2021 13:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230222AbhBONa6 (ORCPT ); Mon, 15 Feb 2021 08:30:58 -0500 Received: from mga02.intel.com ([134.134.136.20]:11742 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhBONak (ORCPT ); Mon, 15 Feb 2021 08:30:40 -0500 IronPort-SDR: BGY6DJYlDlph3e2TK+3NZCQ6IEZF61tb/6TxUj7hKhlhMPyDhiEZIzn3l8K2kUGMP3i4FygKgf HJMJfY93H6Xg== X-IronPort-AV: E=McAfee;i="6000,8403,9895"; a="169812610" X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="169812610" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:28:54 -0800 IronPort-SDR: DIXmMMJmAz3vR9XHDZCRkouf+7yLMNdrRd3hwF38/eCUwr9xCTdKhqATzOI+b0PRNdDIPxpq/4 IZe7uWHk3GWw== X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="438551218" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:28:52 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lBdvk-005CVS-Oj; Mon, 15 Feb 2021 15:28:48 +0200 Date: Mon, 15 Feb 2021 15:28:48 +0200 From: Andy Shevchenko To: Dejin Zheng Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, wsa@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place Message-ID: References: <20210214064529.481341-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Feb 15, 2021 at 03:20:40PM +0200, Andy Shevchenko wrote: > On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote: > > Consolidate pci_free_irq_vectors to a single place using "goto free_irq" > > for simplify the code. FYI, you may rather to introduce a pcim_alloc_irq_vectors() and drop all these calls altogether. Note to everybody: PCIm is not ideal, but this piece is being called whenever pcim_enable_device() makes resources manageable. The problem here is the naming. -- With Best Regards, Andy Shevchenko