Re: [PATCH v1 2/4] Documentation: devres: add pcim_alloc_irq_vectors()

Krzysztof Wilczyński
2021-02-15T21:42:29Z

Hello Dejin,

[...]
> add pcim_alloc_irq_vectors(), a explicit device-managed version of
> pci_alloc_irq_vectors().

It would be "Add" at the start of the sentence. You could also drop
the "explicit" word or replace it with "an explicit", if you want to
keep it.

Generally, this commit message could be improved - you could explain
that you are updating the documentation to reflect the addition of this
new function called pcim_alloc_irq_vectors(), and also briefly explain
why it was added, etc.

[...]
> devm_pci_remap_cfg_resource() : ioremap PCI configuration space resource
> + pcim_alloc_irq_vectors() : managed irq vectors allocation
[...]

It would be "IRQ" here.

Krzysztof