From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CB3C433DB for ; Wed, 31 Mar 2021 06:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21D7C6192E for ; Wed, 31 Mar 2021 06:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233705AbhCaGPM (ORCPT ); Wed, 31 Mar 2021 02:15:12 -0400 Received: from muru.com ([72.249.23.125]:49140 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233694AbhCaGPE (ORCPT ); Wed, 31 Mar 2021 02:15:04 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9068B80C3; Wed, 31 Mar 2021 06:16:06 +0000 (UTC) Date: Wed, 31 Mar 2021 09:15:00 +0300 From: Tony Lindgren To: Heikki Krogerus Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Aaro Koskinen Subject: Re: [PATCH 03/12] ARM: omap1: osk: Constify the software node Message-ID: References: <20210329105047.51033-1-heikki.krogerus@linux.intel.com> <20210329105047.51033-4-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210329105047.51033-4-heikki.krogerus@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org * Heikki Krogerus [210329 10:51]: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Aaro Koskinen > Cc: Tony Lindgren Probably best to merge this via the rest of the series: Acked-by: Tony Lindgren > --- > arch/arm/mach-omap1/board-osk.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c > index 0a4c9b0b13b0c..e18b6f13300eb 100644 > --- a/arch/arm/mach-omap1/board-osk.c > +++ b/arch/arm/mach-omap1/board-osk.c > @@ -332,11 +332,15 @@ static const struct property_entry mistral_at24_properties[] = { > { } > }; > > +static const struct software_node mistral_at24_node = { > + .properties = mistral_at24_properties, > +}; > + > static struct i2c_board_info __initdata mistral_i2c_board_info[] = { > { > /* NOTE: powered from LCD supply */ > I2C_BOARD_INFO("24c04", 0x50), > - .properties = mistral_at24_properties, > + .swnode = &mistral_at24_node, > }, > /* TODO when driver support is ready: > * - optionally ov9640 camera sensor at 0x30 > -- > 2.30.2 >