From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45582C433ED for ; Wed, 14 Apr 2021 19:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 134ED61244 for ; Wed, 14 Apr 2021 19:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352037AbhDNTOe (ORCPT ); Wed, 14 Apr 2021 15:14:34 -0400 Received: from mga17.intel.com ([192.55.52.151]:6090 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234810AbhDNTOd (ORCPT ); Wed, 14 Apr 2021 15:14:33 -0400 IronPort-SDR: xBgx9sbQT3IsgryJ/amAmSLeUiPG+Uas9BMJKmEL+oPXF2KKYdtzI+/W0BMhHrNfIYztL7dlDy 8NqnkyCNWhRQ== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="174820144" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="174820144" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 12:14:11 -0700 IronPort-SDR: zikZ0vApu1KHhNyZ89lWF495VbGWfFolKVkrJN9M51UT0i2Lon4fSa5vXCxs5GuOmtk7olwrHP gwjNJYORAKQQ== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="382464970" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 12:14:08 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lWkxg-00456I-Uc; Wed, 14 Apr 2021 22:14:04 +0300 Date: Wed, 14 Apr 2021 22:14:04 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Yicong Yang , Wei Xu , Wolfram Sang , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List , Linuxarm Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI Message-ID: References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko > wrote: > > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: > > > > On 2021/4/13 20:26, Geert Uytterhoeven wrote: > > > > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > > > > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > > > > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user > > > > > about this driver when configuring a kernel without Hisilicon platform > > > > > or ACPI firmware support. > > > > > > > > this is a public IP which doesn't specifically depend on ARCH_HISI. I'm > > > > not sure all the platform this IP on has ARCH_HISI configured. The driver > > > > will not be compiled by default config. This is not correct to have > > > > this dependence. > > > > > > Thanks for your answer! > > > > > > I guess it's still fine to add a dependency on ACPI? > > > > But why? > > Please tell me how/when the driver is used when CONFIG_ACPI=n. I'm not using it at all. Ask the author :-) But if we follow your logic, then we need to mark all the _platform_ drivers for x86 world as ACPI dependent? This sounds ugly. So, if you are going to send a such patch, NAK here from me. Same here. NAK. -- With Best Regards, Andy Shevchenko