From: Tony Lindgren <tony@atomide.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format
Date: Wed, 5 May 2021 10:18:08 +0300 [thread overview]
Message-ID: <YJJGsGXBz56Nhe8z@atomide.com> (raw)
In-Reply-To: <20210505065511.918-1-vigneshr@ti.com>
Hi,
* Vignesh Raghavendra <vigneshr@ti.com> [210505 06:55]:
> Convert i2c-omap.txt to YAML schema for better checks and documentation.
Nice to see this happening, few minor comments below on handling the
legacy devices.
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,omap2420-i2c
> + - const: ti,omap2430-i2c
> + - const: ti,omap3-i2c
> + - const: ti,omap4-i2c
> + - items:
> + - enum:
> + - ti,am4372-i2c
> + - ti,am64-i2c
> + - ti,am654-i2c
> + - ti,j721e-i2c
> + - const: ti,omap4-i2c
I wonder if we should just add all the compatible options to the
driver, and have all these as oneOf?
> + ti,hwmods:
> + description:
> + Must be "i2c<n>", n being the instance number (1-based)
> + $ref: /schemas/types.yaml#/definitions/string
> + items:
> + - pattern: "^i2c([1-9])$"
The ti,hwmods is a legacy property that is only needed for omap2/3 and
ti81xx. At least the description should mention that to avoid folks
adding it accidentally.
Regards,
Tony
next prev parent reply other threads:[~2021-05-05 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 6:55 [PATCH] dt-bindings: i2c: Move i2c-omap.txt to YAML format Vignesh Raghavendra
2021-05-05 7:18 ` Tony Lindgren [this message]
2021-05-05 18:04 ` Vignesh Raghavendra
2021-05-05 20:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJJGsGXBz56Nhe8z@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).