From: Wolfram Sang <wsa@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: mpc: Restore reread of I2C status register
Date: Fri, 2 Jul 2021 09:53:08 +0200 [thread overview]
Message-ID: <YN7F5Kv6NbD/6GBK@kunai> (raw)
In-Reply-To: <20210702032724.4370-1-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Fri, Jul 02, 2021 at 03:27:24PM +1200, Chris Packham wrote:
> Prior to commit 1538d82f4647 ("i2c: mpc: Interrupt driven transfer") the
> old interrupt handler would reread MPC_I2C_SR after checking the CSR_MIF
> bit. When the driver was re-written this was removed as it seemed
> unnecessary. However as it turns out this is necessary for i2c devices
> which do clock stretching otherwise we end up thinking the bus is still
> busy when processing the interrupt.
>
> Fixes: 1538d82f4647 ("i2c: mpc: Interrupt driven transfer")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-02 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 3:27 [PATCH] i2c: mpc: Restore reread of I2C status register Chris Packham
2021-07-02 7:53 ` Wolfram Sang [this message]
2021-07-08 2:03 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7F5Kv6NbD/6GBK@kunai \
--to=wsa@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox