* [PATCH] i2c: ali1535: mention that the device should not be disabled
@ 2021-06-25 15:17 Wolfram Sang
2021-07-01 12:14 ` Jean Delvare
2021-07-02 7:53 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-06-25 15:17 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Jean Delvare
The comment from the i801 driver is valid here, too, so copy it.
Reported-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
---
drivers/i2c/busses/i2c-ali1535.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index fb93152845f4..ee83c4581bce 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev)
{
i2c_del_adapter(&ali1535_adapter);
release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
+
+ /*
+ * do not call pci_disable_device(dev) since it can cause hard hangs on
+ * some systems during power-off
+ */
}
static struct pci_driver ali1535_driver = {
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: ali1535: mention that the device should not be disabled
2021-06-25 15:17 [PATCH] i2c: ali1535: mention that the device should not be disabled Wolfram Sang
@ 2021-07-01 12:14 ` Jean Delvare
2021-07-02 7:53 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2021-07-01 12:14 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c
On Fri, 25 Jun 2021 17:17:58 +0200, Wolfram Sang wrote:
> The comment from the i801 driver is valid here, too, so copy it.
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> ---
> drivers/i2c/busses/i2c-ali1535.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
> index fb93152845f4..ee83c4581bce 100644
> --- a/drivers/i2c/busses/i2c-ali1535.c
> +++ b/drivers/i2c/busses/i2c-ali1535.c
> @@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev)
> {
> i2c_del_adapter(&ali1535_adapter);
> release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
> +
> + /*
> + * do not call pci_disable_device(dev) since it can cause hard hangs on
> + * some systems during power-off
> + */
> }
>
> static struct pci_driver ali1535_driver = {
Can't hurt.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: ali1535: mention that the device should not be disabled
2021-06-25 15:17 [PATCH] i2c: ali1535: mention that the device should not be disabled Wolfram Sang
2021-07-01 12:14 ` Jean Delvare
@ 2021-07-02 7:53 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-07-02 7:53 UTC (permalink / raw)
To: linux-i2c; +Cc: Jean Delvare
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
On Fri, Jun 25, 2021 at 05:17:58PM +0200, Wolfram Sang wrote:
> The comment from the i801 driver is valid here, too, so copy it.
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-02 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-25 15:17 [PATCH] i2c: ali1535: mention that the device should not be disabled Wolfram Sang
2021-07-01 12:14 ` Jean Delvare
2021-07-02 7:53 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).