Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

Wolfram Sang
2021-06-29T11:48:47Z

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

> > Obviously, I don't know much about the specs and their wording. Still I
> > wonder if we can't call it a zero length transfer?
>
> Maybe that.

I'd prefer it.

> > This is allowed by
> > the I2C standard and SMBus has even a proper name for it (SMBUS_QUICK).
> > From my point of view, I would not say it is device specific because
> > devices are expected to ACK such a message.
>
> Actually we should skip the last line from my diff, i.e. completely
> drop "and result for such a request is I2C device specific".

Sounds good.

> The device (host in virtio spec terminology) still needs to return
> success/failure as it does for other requests. Nothing special here.

Ack.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]