Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

Wolfram Sang
2021-06-30T07:32:26Z

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

> > > + snprintf(vi->adap.name, sizeof(vi->adap.name), "Virtio I2C Adapter");
> > Is there something to add so you can distinguish multiple instances?
> > Most people want that.
>
>
> I find the I2C core will set a device name "i2c-%d" for this purpose, right?
>
> I think this name can be used to distinguish the adapter types while
> "i2c-%d" can be used to
>
> distinguish instances. Does it make sense ?

That alone does not help. See the 'i2cdetect -l' output of my Renesas
board here:

i2c-4 i2c e66d8000.i2c I2C adapter
i2c-2 i2c e6510000.i2c I2C adapter
i2c-7 i2c e60b0000.i2c I2C adapter

Notice that the third column carries the base address, so you know which
i2c-%d is which physical bus. I don't know if it makes sense in your
"virtual" case, but so far it would always print "Virtio I2C Adapter".
Maybe it makes sense to add some parent device name, too?

And if this is not reasonable, just skip it. As I said, it can be
helpful at times, but it is definately not a show stopper.

> > > + vi->adap.timeout = HZ / 10;
> > Why so short? HZ is the kinda default value.
>
>
> Ah... I didn't know the I2C core had already set a default value.
> I will remove this line to use the default one.

Sounds good.

Looking forward to the next version!

Happy hacking,

Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]