From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0704EC4338F for ; Wed, 28 Jul 2021 09:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA1B860F9E for ; Wed, 28 Jul 2021 09:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231701AbhG1Jfv (ORCPT ); Wed, 28 Jul 2021 05:35:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:50718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbhG1Jfu (ORCPT ); Wed, 28 Jul 2021 05:35:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FEBF60F9C; Wed, 28 Jul 2021 09:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627464949; bh=BQ7AJ0x7vUvZcwd7pGg5I9RZxeFcT+nYuKI9gEJYQD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IV9CVPy02b0NS62XMVEnR2So9X+6ZfwJcp6E/kI8FQU9Zqt3EDfPAK+B4T6JiWFss mpcy9WtMVn6DqCSFpM9uPKZd/b+T8Ju/I0dgdtcTGmUA39BFMn1VdEy7xP0oYYSxzp b9oyk+nzMWfuVT36lsVYzJ8a3TwxsejeinHr815fNZLJRWM84HkBNfvUxzghw4yiGU 5FGctyzl/E+HTtTWLTe/woBIQGfGuq5ipSqLL0vpRQk4zs245IdL6sgqLYz10zrPsK T9n85ilY3M0s/F89pqc8UFuI7nIbJ0D1vXd90lGzfHlPi/gtTafxIoJwgmMLYdGp47 vvNILMvuW6EVw== Date: Wed, 28 Jul 2021 11:35:46 +0200 From: Wolfram Sang To: Heiner Kallweit Cc: Jean Delvare , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH v2] i2c: i801: Fix handling SMBHSTCNT_PEC_EN Message-ID: Mail-Followup-To: Wolfram Sang , Heiner Kallweit , Jean Delvare , "linux-i2c@vger.kernel.org" References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DXbkOj5MWMIt9vUh" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --DXbkOj5MWMIt9vUh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 27, 2021 at 10:25:25PM +0200, Heiner Kallweit wrote: > Bit SMBHSTCNT_PEC_EN is used only if software calculates the CRC and > uses register SMBPEC. This is not supported by the driver, it supports > hw-calculation of CRC only (using bit SMBAUXSTS_CRCE). The chip spec > states the following, therefore never set bit SMBHSTCNT_PEC_EN. >=20 > Chapter SMBus CRC Generation and Checking > If the AAC bit is set in the Auxiliary Control register, the PCH > automatically calculates and drives CRC at the end of the transmitted > packet for write cycles, and will check the CRC for read cycles. It will > not transmit the contents of the PEC register for CRC. The PEC bit must > not be set in the Host Control register. If this bit is set, unspecified > behavior will result. >=20 > This patch is based solely on the specification and compile-tested only, > because I have no PEC-capable devices. >=20 > Signed-off-by: Heiner Kallweit > Tested-by: Jean Delvare Applied to for-next, thanks! --DXbkOj5MWMIt9vUh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmEBJPIACgkQFA3kzBSg KbbjHQ//W/rUcvVZ3xSCqe9sDuK2C/iflx7hZ0Mzvmc+8Tv9jcrTmD20MZ0xlsrn zp9iSwaBjmlqeASuw138bNOn7k/KBwT54iig8/UiPizazstIyBY3qvsc7pdLn35j +3G1JE/aLiZQscuye/apI0eBGCXq0gl7fxDApsvx4wzzdlD03xTRiuXe6gHNO4BV T2Lmeh/0tcX0DaYhf5OPZBycyRq3AWCA8PU3+UJBCEWoOJS/0v8iotN+AxDRt4I4 CbTxjUvxbAJy+DNnzwM95CBQivWqoBrI/WsU7djBGtU8TRPO1gYrPpb83RMGLZ6+ N4eMHLocbXdmYE2n1vpXqqlbUPCYuBbx8C2I4J+mig3/r4eVolCNvKkgrnNLHSp5 jtf6bOO/dEHqrZLeD3lA/ogsrpgZPjGMfjwYoTyC75lWbAjXME8ovPRCgi0JxZGU sQjirdW4L2RAvpGUl69MC9RbH6HJua/b6hVp/VvpcsclNzcm+VuRyuEw/ETAAx76 SYTPXi6VIsNthtwygu+Yavoh8VGnEhJPhAg9+I9NjWaxVhgLTuhQEFU3yA6pMGh5 elPCyQj1B8lSACYXk9zysialFOuZtDkbTO0SsoNHXQTuDYr3s6wCtPXPi6rQcZ6r F41l6hbE/mY06Tl1/GVBRGFpVhEmOODhfee82BXFG502FLk1FVc= =ayBw -----END PGP SIGNATURE----- --DXbkOj5MWMIt9vUh--