From: Wolfram Sang <wsa@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: highlander: add IRQ check
Date: Tue, 3 Aug 2021 22:49:03 +0200 [thread overview]
Message-ID: <YQmrv+0K3vqFuVG8@kunai> (raw)
In-Reply-To: <4be958f5-3e6c-e536-9d51-1de8664ccaaa@omp.ru>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Sun, May 30, 2021 at 10:13:45PM +0300, Sergey Shtylyov wrote:
> The driver is written as if platform_get_irq() returns 0 on errors (while
> actually it returns a negative error code), blithely passing these error
> codes to request_irq() (which takes *unsigned* IRQ #) -- which fails with
> -EINVAL. Add the necessary error check to the pre-existing *if* statement
> forcing the driver into the polling mode...
>
> Fixes: 4ad48e6ab18c ("i2c: Renesas Highlander FPGA SMBus support")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-08-03 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 19:13 [PATCH] i2c: highlander: add IRQ check Sergey Shtylyov
2021-08-03 20:49 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQmrv+0K3vqFuVG8@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox