From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF05C4338F for ; Wed, 11 Aug 2021 15:41:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48B4160FA0 for ; Wed, 11 Aug 2021 15:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232832AbhHKPmM (ORCPT ); Wed, 11 Aug 2021 11:42:12 -0400 Received: from mga05.intel.com ([192.55.52.43]:55249 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232120AbhHKPmL (ORCPT ); Wed, 11 Aug 2021 11:42:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="300734377" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="300734377" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 08:41:48 -0700 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="484953160" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 08:41:46 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mDqMO-008BtO-NY; Wed, 11 Aug 2021 18:41:40 +0300 Date: Wed, 11 Aug 2021 18:41:40 +0300 From: Andy Shevchenko To: Heiner Kallweit Cc: Jean Delvare , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH v2 1/9] i2c: i801: Improve disabling runtime pm Message-ID: References: <10690555-2317-4916-70b8-870708858f9b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10690555-2317-4916-70b8-870708858f9b@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Aug 06, 2021 at 11:12:18PM +0200, Heiner Kallweit wrote: > Setting the autosuspend delay to a negative value disables runtime pm in > a little bit smarter way, because we need no cleanup when removing the > driver. Note that this is safe when reloading the driver, because the > call to pm_runtime_set_autosuspend_delay() in probe() will reverse the > effect. See update_autosuspend() for details. ... > * BIOS is accessing the host controller so prevent it from > * suspending automatically from now on. > */ > - pm_runtime_get_sync(&pdev->dev); > + pm_runtime_set_autosuspend_delay(&pdev->dev, -1); I dunno if it's being discussed, but with this you effectively allow user to override the setting. It may screw things up AFAIU the comment above. -- With Best Regards, Andy Shevchenko