From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B18C432BE for ; Wed, 11 Aug 2021 15:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA72F60041 for ; Wed, 11 Aug 2021 15:43:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233364AbhHKPoQ (ORCPT ); Wed, 11 Aug 2021 11:44:16 -0400 Received: from mga05.intel.com ([192.55.52.43]:55438 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233350AbhHKPoQ (ORCPT ); Wed, 11 Aug 2021 11:44:16 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="300734698" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="300734698" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 08:43:52 -0700 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="590134580" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 08:43:51 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mDqOQ-008BvL-24; Wed, 11 Aug 2021 18:43:46 +0300 Date: Wed, 11 Aug 2021 18:43:46 +0300 From: Andy Shevchenko To: Heiner Kallweit Cc: Jean Delvare , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH v2 2/9] i2c: i801: make p2sb_spinlock a mutex Message-ID: References: <90aee333-6490-db08-01ae-c0de1e18368a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90aee333-6490-db08-01ae-c0de1e18368a@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Aug 06, 2021 at 11:13:29PM +0200, Heiner Kallweit wrote: > p2sb_spinlock is used in i801_add_tco_spt() only, and in process context > only. Therefore a mutex is sufficient, and we can make the definition > local to i801_add_tco_spt(). The problem with either AFAICT is that it should actually hold PCI rescan lock. See the discussion with Message-ID 20210308122020.57071-1-andriy.shevchenko@linux.intel.com for the details. -- With Best Regards, Andy Shevchenko