From: Wolfram Sang <wsa@kernel.org>
To: Jamie Iles <quic_jiles@quicinc.com>
Cc: linux-i2c@vger.kernel.org,
Octavian Purdila <octavian.purdila@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] i2c / ACPI: fix resource leak in reconfiguration device addition
Date: Wed, 29 Sep 2021 22:56:39 +0200 [thread overview]
Message-ID: <YVTTB//qSm7bLCy4@kunai> (raw)
In-Reply-To: <20210922165718.179585-1-quic_jiles@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Wed, Sep 22, 2021 at 05:57:18PM +0100, Jamie Iles wrote:
> acpi_i2c_find_adapter_by_handle() calls bus_find_device() which takes a
> reference on the adapter which is never released which will result in a
> reference count leak and render the adapter unremovable. Make sure to
> put the adapter after creating the client in the same manner that we do
> for OF.
>
> Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications")
> Cc: Octavian Purdila <octavian.purdila@intel.com>
> Cc: Wolfram Sang <wsa@kernel.org>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-09-29 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 16:57 [PATCH] i2c / ACPI: fix resource leak in reconfiguration device addition Jamie Iles
2021-09-23 6:51 ` Mika Westerberg
2021-09-29 20:56 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVTTB//qSm7bLCy4@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=octavian.purdila@intel.com \
--cc=quic_jiles@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox