From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1 3/3] mfd: tps80031: Remove driver
Date: Fri, 22 Oct 2021 10:54:49 +0100 [thread overview]
Message-ID: <YXKKaaNeu4EIjmFq@google.com> (raw)
In-Reply-To: <b8f6dffb-ec7b-c105-51f1-7b761e331a89@gmail.com>
On Fri, 22 Oct 2021, Dmitry Osipenko wrote:
> 22.10.2021 11:05, Lee Jones пишет:
> > On Thu, 21 Oct 2021, Dmitry Osipenko wrote:
> >
> >> Driver was upstreamed in 2013 and never got a user, remove it.
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >> ---
> >> drivers/mfd/Kconfig | 14 -
> >> drivers/mfd/Makefile | 1 -
> >> drivers/mfd/tps80031.c | 526 -----------------------------
> >> include/linux/mfd/tps80031.h | 637 -----------------------------------
> >> 4 files changed, 1178 deletions(-)
> >> delete mode 100644 drivers/mfd/tps80031.c
> >> delete mode 100644 include/linux/mfd/tps80031.h
> >
> >> -static const struct i2c_device_id tps80031_id_table[] = {
> >> - { "tps80031", TPS80031 },
> >> - { "tps80032", TPS80032 },
> >> - { }
> >> -};
> >
> > This is an I2C driver, right?
> >
> > I was under the impression that Linux could do auto-probing on I2C
> > devices? Such that they do not require platform code or DT in order
> > to bind?
> >
>
> It's I2C driver. I'm not sure about auto-probing because something
> should provide information about device to Linux. It's possible to
> detect/scan whether there is device sitting on I2C address, but there is
> no auto-discovery mechanism, AFAIK.
>
> TPS80031 device will fail to bind to this driver because it explicitly
> requires platform data which should be NULL if device is probed solely
> by I2C ID.
This is a fair point.
I'll take the patch, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-10-22 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211021192258.21968-1-digetx@gmail.com>
[not found] ` <20211021192258.21968-4-digetx@gmail.com>
2021-10-22 8:05 ` [PATCH v1 3/3] mfd: tps80031: Remove driver Lee Jones
2021-10-22 8:20 ` Dmitry Osipenko
2021-10-22 8:46 ` Wolfram Sang
2021-10-22 8:50 ` Dmitry Osipenko
2021-10-22 9:54 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXKKaaNeu4EIjmFq@google.com \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).