From: Wolfram Sang <wsa@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: mans@mansr.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] i2c: xlr: Fix a resource leak in the error handling path of 'xlr_i2c_probe()'
Date: Fri, 29 Oct 2021 22:05:55 +0200 [thread overview]
Message-ID: <YXxUIw02XJqVvus3@kunai> (raw)
In-Reply-To: <e928fd285b37599e1f6648d0b963de8ed7773166.1629405992.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Thu, Aug 19, 2021 at 10:48:08PM +0200, Christophe JAILLET wrote:
> A successful 'clk_prepare()' call should be balanced by a corresponding
> 'clk_unprepare()' call in the error handling path of the probe, as already
> done in the remove function.
>
> More specifically, 'clk_prepare_enable()' is used, but 'clk_disable()' is
> also already called. So just the unprepare step has still to be done.
>
> Update the error handling path accordingly.
>
> Fixes: 75d31c2372e4 ("i2c: xlr: add support for Sigma Designs controller variant")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-29 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 20:48 [PATCH] i2c: xlr: Fix a resource leak in the error handling path of 'xlr_i2c_probe()' Christophe JAILLET
2021-10-29 20:05 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXxUIw02XJqVvus3@kunai \
--to=wsa@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).