From: "Krzysztof Wilczyński" <kw@linux.com>
To: "Robert Święcki" <robert@swiecki.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Bjorn Helgaas" <helgaas@kernel.org>,
linux-i2c@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: Don't call resume callback for nearly bound devices
Date: Tue, 9 Nov 2021 01:00:15 +0100 [thread overview]
Message-ID: <YYm6D0YMGEXGFsZL@rocinante> (raw)
In-Reply-To: <CAP145phFHh+pMTXbdwwQK6bgxLBcF2JgQKwz2L+2vJRs2dMiVg@mail.gmail.com>
Hello!
[...]
> > I didn't test this patch, @Robert, maybe you can do this?
> >
> > Best regards
> > Uwe
> >
> > drivers/pci/pci-driver.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> > index 1d98c974381c..202533654012 100644
> > --- a/drivers/pci/pci-driver.c
> > +++ b/drivers/pci/pci-driver.c
> > @@ -1299,7 +1299,7 @@ static int pci_pm_runtime_resume(struct device *dev)
> > */
> > pci_restore_standard_config(pci_dev);
> >
> > - if (!to_pci_driver(dev->driver))
> > + if (!device_is_bound(dev))
> > return 0;
> >
> > pci_fixup_device(pci_fixup_resume_early, pci_dev);
>
> Yes, that fixes it. Thanks for the patch.
Thank you Uwe for the patch and Robert for testing!
Krzysztof
next prev parent reply other threads:[~2021-11-09 0:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAP145pgwt7svtDwcD=AStKTt_GSN-ZqPL2u74Y63TAY5ghAagQ@mail.gmail.com>
[not found] ` <CAP145pgrL-tOHrxsKwk_yzQihyk4TMFrgBb6zhNgC1i2wUTCeQ@mail.gmail.com>
2021-11-08 15:37 ` Fwd: Crashes in 5.15-git in i2c code Robert Święcki
2021-11-08 16:34 ` Robert Święcki
2021-11-08 18:58 ` Bjorn Helgaas
2021-11-08 19:09 ` Bjorn Helgaas
2021-11-08 21:22 ` [PATCH] pci: Don't call resume callback for nearly bound devices Uwe Kleine-König
2021-11-08 21:36 ` Robert Święcki
2021-11-09 0:00 ` Krzysztof Wilczyński [this message]
2021-11-09 2:56 ` Bjorn Helgaas
2021-11-09 6:42 ` Greg Kroah-Hartman
2021-11-09 6:59 ` Uwe Kleine-König
2021-11-09 17:18 ` Rafael J. Wysocki
2021-11-09 18:12 ` Bjorn Helgaas
2021-11-09 18:52 ` Rafael J. Wysocki
2021-11-09 18:58 ` Rafael J. Wysocki
2021-11-09 20:05 ` Bjorn Helgaas
2021-11-09 20:43 ` Uwe Kleine-König
2021-11-10 14:14 ` Bjorn Helgaas
2021-11-10 16:33 ` Robert Święcki
2021-11-10 16:48 ` Rafael J. Wysocki
2021-11-10 17:59 ` Bjorn Helgaas
2021-11-10 21:19 ` Bjorn Helgaas
2021-11-11 17:01 ` Bjorn Helgaas
2021-11-11 17:32 ` Robert Święcki
2021-11-11 18:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYm6D0YMGEXGFsZL@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert@swiecki.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).