* [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz
@ 2021-10-29 14:11 David Heidelberg
2021-11-01 7:20 ` Oleksij Rempel
2021-11-08 20:58 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: David Heidelberg @ 2021-10-29 14:11 UTC (permalink / raw)
To: Oleksij Rempel, Pengutronix Kernel Team, Rob Herring, Shawn Guo,
Sascha Hauer, Fabio Estevam, NXP Linux Team, Anson Huang
Cc: ~okias/devicetree, David Heidelberg, Oleksij Rempel, Rob Herring,
linux-i2c, devicetree, linux-arm-kernel, linux-kernel
clock-frequency is only restricted by the upper limit of 400 kHz.
Found with:
$ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
...
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
...
Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
index 3592d49235e0..c167958ae2a9 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
@@ -57,7 +57,9 @@ properties:
const: ipg
clock-frequency:
- enum: [ 100000, 400000 ]
+ minimum: 1
+ default: 100000
+ maximum: 400000
dmas:
items:
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz
2021-10-29 14:11 [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz David Heidelberg
@ 2021-11-01 7:20 ` Oleksij Rempel
2021-11-08 20:58 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Oleksij Rempel @ 2021-11-01 7:20 UTC (permalink / raw)
To: David Heidelberg
Cc: Oleksij Rempel, Pengutronix Kernel Team, Rob Herring, Shawn Guo,
Sascha Hauer, Fabio Estevam, NXP Linux Team, Anson Huang,
~okias/devicetree, Rob Herring, linux-i2c, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Oct 29, 2021 at 04:11:33PM +0200, David Heidelberg wrote:
> clock-frequency is only restricted by the upper limit of 400 kHz.
>
> Found with:
> $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
> From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> ...
>
> Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index 3592d49235e0..c167958ae2a9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -57,7 +57,9 @@ properties:
> const: ipg
>
> clock-frequency:
> - enum: [ 100000, 400000 ]
> + minimum: 1
> + default: 100000
> + maximum: 400000
>
> dmas:
> items:
> --
> 2.33.0
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz
2021-10-29 14:11 [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz David Heidelberg
2021-11-01 7:20 ` Oleksij Rempel
@ 2021-11-08 20:58 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-11-08 20:58 UTC (permalink / raw)
To: David Heidelberg
Cc: Sascha Hauer, Anson Huang, Fabio Estevam, linux-arm-kernel,
Pengutronix Kernel Team, Oleksij Rempel, linux-kernel, devicetree,
Oleksij Rempel, NXP Linux Team, Rob Herring, linux-i2c, Shawn Guo,
~okias/devicetree
On Fri, 29 Oct 2021 16:11:33 +0200, David Heidelberg wrote:
> clock-frequency is only restricted by the upper limit of 400 kHz.
>
> Found with:
> $ DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-imx.yaml make dtbs_check
> ...
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
> From schema: linux/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> ...
>
> Fixes: 4bdc44347299 ("dt-bindings: i2c: Convert imx i2c to json-schema")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-08 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-29 14:11 [PATCH] dt-bindings: i2c: imx: hardware do not restrict clock-frequency to only 100 and 400 kHz David Heidelberg
2021-11-01 7:20 ` Oleksij Rempel
2021-11-08 20:58 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).