From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27BA1C433EF for ; Mon, 15 Nov 2021 11:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F180B61B3A for ; Mon, 15 Nov 2021 11:03:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231184AbhKOLGs (ORCPT ); Mon, 15 Nov 2021 06:06:48 -0500 Received: from mga02.intel.com ([134.134.136.20]:23099 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237823AbhKOLEy (ORCPT ); Mon, 15 Nov 2021 06:04:54 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="220630228" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="220630228" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 03:01:56 -0800 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="493975370" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 03:01:55 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mmZkA-0072KN-P2; Mon, 15 Nov 2021 13:01:46 +0200 Date: Mon, 15 Nov 2021 13:01:46 +0200 From: Andy Shevchenko To: "Wang, Lawrence (NSB - CN/Hangzhou)" Cc: "jarkko.nikula@linux.intel.com" , "mika.westerberg@linux.intel.com" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Wang@wrlinb193.emea.nsn-net.net" Subject: Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts Message-ID: References: <20211115093556.7154-1-lawrence.wang@nokia-sbell.com> <587c61a76c8547d0a36dd11071bfcb2d@nokia-sbell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <587c61a76c8547d0a36dd11071bfcb2d@nokia-sbell.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Nov 15, 2021 at 10:41:06AM +0000, Wang, Lawrence (NSB - CN/Hangzhou) wrote: Please, do not top post! > Besides the fact it misses DT schema update, why this is needed at all? > ------> we need a interface to configure the HCNT/LCNT via dts (current we just have ACPI to config it). > What's wrong with the existing DT timings? > --------> the HCNT/LCNT value calculated by code is not accuracy. This is similar changes as the ACPI interface. So, _this_ is a problem, try to fix it instead of band aiding here and there. P.S. You forgot to include proper people in the Cc list. I recommend to consider using my script [1] for sending patches. [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh -- With Best Regards, Andy Shevchenko