Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts

Andy Shevchenko
2021-11-15T11:03:57Z

On Mon, Nov 15, 2021 at 10:41:06AM +0000, Wang, Lawrence (NSB - CN/Hangzhou) wrote:

Please, do not top post!

> Besides the fact it misses DT schema update, why this is needed at all?
> ------> we need a interface to configure the HCNT/LCNT via dts (current we just have ACPI to config it).
> What's wrong with the existing DT timings?
> --------> the HCNT/LCNT value calculated by code is not accuracy. This is similar changes as the ACPI interface.

So, _this_ is a problem, try to fix it instead of band aiding here and there.

P.S. You forgot to include proper people in the Cc list. I recommend to
consider using my script [1] for sending patches.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh