From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F9E9C433F5 for ; Tue, 16 Nov 2021 10:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0537360F44 for ; Tue, 16 Nov 2021 10:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234303AbhKPKp7 (ORCPT ); Tue, 16 Nov 2021 05:45:59 -0500 Received: from mga07.intel.com ([134.134.136.100]:16239 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234596AbhKPKpj (ORCPT ); Tue, 16 Nov 2021 05:45:39 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="297091372" X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="297091372" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 02:42:39 -0800 X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="504520815" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 02:42:38 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mmvv4-007OBo-7L; Tue, 16 Nov 2021 12:42:30 +0200 Date: Tue, 16 Nov 2021 12:42:29 +0200 From: Andy Shevchenko To: Jean Delvare Cc: Jarkko Nikula , linux-i2c@vger.kernel.org, Wolfram Sang , ck+kernelbugzilla@bl4ckb0x.de, stephane.poignant@protonmail.com Subject: Re: [PATCH v3] i2c: i801: Fix interrupt storm from SMB_ALERT signal Message-ID: References: <20211110141032.2429745-1-jarkko.nikula@linux.intel.com> <71a5c6d4-4ae8-2c54-78e7-94a37b43a986@linux.intel.com> <20211116111821.75ba4ea6@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211116111821.75ba4ea6@endymion> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, Nov 16, 2021 at 11:18:21AM +0100, Jean Delvare wrote: > On Thu, 11 Nov 2021 16:39:28 +0200, Jarkko Nikula wrote: > > On 11/10/21 7:16 PM, Andy Shevchenko wrote: > > > On Wed, Nov 10, 2021 at 04:10:32PM +0200, Jarkko Nikula wrote: > > >> /* > > >> - * Clear irq sources and report transaction result. > > >> + * Clear remaining irq sources: Completion of last command, errors > > >> + * and the SMB_ALERT signal. SMB_ALERT status is set after signal > > >> + * assertion independently is the interrupt generation blocked or not > > > > > > is --> if ? > > > > hmm, I don't know which one is correct or neither. Or should it be > > something like "independently of whether the interrupt generation is > > blocked or not"? Grammar polices, please help me :-) > > ... independently of the interrupt generation being blocked or not. > > Sounds better? > > (I think your "of whether" variant is grammatically correct too, if you > prefer that.) For the sake of bikeshedding :-) I lean to "whether" variant, because I think the determiner usage is decreasing over time, while its presence makes language richer. -- With Best Regards, Andy Shevchenko