From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
ck+kernelbugzilla@bl4ckb0x.de, stephane.poignant@protonmail.com
Subject: Re: [PATCH v3] i2c: i801: Fix interrupt storm from SMB_ALERT signal
Date: Tue, 16 Nov 2021 12:43:59 +0200 [thread overview]
Message-ID: <YZOLb2gb5LtwiiTR@smile.fi.intel.com> (raw)
In-Reply-To: <YZOLFSpQqw1haCC2@smile.fi.intel.com>
On Tue, Nov 16, 2021 at 12:42:30PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 16, 2021 at 11:18:21AM +0100, Jean Delvare wrote:
> > On Thu, 11 Nov 2021 16:39:28 +0200, Jarkko Nikula wrote:
> > > On 11/10/21 7:16 PM, Andy Shevchenko wrote:
> > > > On Wed, Nov 10, 2021 at 04:10:32PM +0200, Jarkko Nikula wrote:
...
> > > >> + * Clear remaining irq sources: Completion of last command, errors
> > > >> + * and the SMB_ALERT signal. SMB_ALERT status is set after signal
> > > >> + * assertion independently is the interrupt generation blocked or not
> > > >
> > > > is --> if ?
> > >
> > > hmm, I don't know which one is correct or neither. Or should it be
> > > something like "independently of whether the interrupt generation is
> > > blocked or not"? Grammar polices, please help me :-)
> >
> > ... independently of the interrupt generation being blocked or not.
> >
> > Sounds better?
> >
> > (I think your "of whether" variant is grammatically correct too, if you
> > prefer that.)
>
> For the sake of bikeshedding :-) I lean to "whether" variant, because I think
s/"whether"/"of whether"/
> the determiner usage is decreasing over time, while its presence makes language
> richer.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-11-16 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 14:10 [PATCH v3] i2c: i801: Fix interrupt storm from SMB_ALERT signal Jarkko Nikula
2021-11-10 17:16 ` Andy Shevchenko
2021-11-11 14:39 ` Jarkko Nikula
2021-11-16 10:18 ` Jean Delvare
2021-11-16 10:42 ` Andy Shevchenko
2021-11-16 10:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZOLb2gb5LtwiiTR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ck+kernelbugzilla@bl4ckb0x.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=stephane.poignant@protonmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).