linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Rajat Jain <rajatja@google.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, dtor@google.com, rajatxjain@gmail.com,
	dbasehore@chromium.org
Subject: Re: [PATCH v2 0/3] i2c: Enable asynchronous suspend/resume
Date: Mon, 29 Nov 2021 17:48:03 +0100	[thread overview]
Message-ID: <YaUEQwYeUgqlMOmu@kunai> (raw)
In-Reply-To: <20211025213532.2349161-1-rajatja@google.com>

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

Hi,

> As far as I understand, the only reason we might not want a device to be
> marked for asynchronous resume is if we suspect it cannot handle
> concurrent resume with other devices, which does not look to be the
> case. 

Since parent-child relationships are handled, I'd say let us try this.
If there are siblings which depend on each other, I think they should be
marked with "device_link_add" anyhow. I am afraid we will encounter some
regressions with such siblings. However, I don't think there will be a
lot and the time savings for all Linux systems may be worth the
(hopefully) little hazzle.

> This patchset marks the designware, the I2c adapters, and the i2c 
> clients for asynchronous suspend/resume. In case it helps to gain any
> confidence, the patch 3 (for i2c clients) has been included and shipping
> on all our chromebooks for the past 3+ years, and has not shown any
> issues. The designware and i2c adapters should be easier.

This in deed helps to gain confidence. I agree that the clients are
probably the most tricky ones. If that works on all Chromebooks for 3
years now, I am positive we can test this series in linux-next now.

Thanks for this work,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2021-11-29 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 21:35 [PATCH v2 0/3] i2c: Enable asynchronous suspend/resume Rajat Jain
2021-10-25 21:35 ` [PATCH v2 1/3] i2c: designware: Enable async suspend / resume of designware devices Rajat Jain
2021-11-29 16:51   ` Wolfram Sang
2021-10-25 21:35 ` [PATCH 2/3] i2c: enable async suspend/resume for i2c adapters Rajat Jain
2021-11-29 16:51   ` Wolfram Sang
2021-10-25 21:35 ` [PATCH 3/3] i2c: enable async suspend/resume on i2c client devices Rajat Jain
2021-11-29 16:51   ` Wolfram Sang
2021-11-29 16:48 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaUEQwYeUgqlMOmu@kunai \
    --to=wsa@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dbasehore@chromium.org \
    --cc=dtor@google.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rajatja@google.com \
    --cc=rajatxjain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).