From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: rcar: update to new DMAENGINE API when terminating
Date: Thu, 16 Dec 2021 22:23:45 +0100 [thread overview]
Message-ID: <YbuuYVgSRJs1Bt6G@kunai> (raw)
In-Reply-To: <20211208084543.20181-1-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Wed, Dec 08, 2021 at 09:45:42AM +0100, Wolfram Sang wrote:
> dmaengine_terminate_all() is deprecated. When converting the existing
> calls, it turned out that the termination in the interrupt handlers was
> superfluous and only a side effect of simply calling
> rcar_i2c_cleanup_dma(). As either no DMA transfers have been submitted
> yet or the last one has successfully completed, there is nothing to
> terminate and we can leave it out. So, merge the DMA unmap and cleanup
> function to save some code. Then, add a flag if the new cleanup function
> needs to terminate DMA. This is only the case for the erorr handling in
> the main thread, so we can finally switch from dmaengine_terminate_all()
> to dmaengine_terminate_sync() here.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-16 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 8:45 [PATCH 1/2] i2c: rcar: update to new DMAENGINE API when terminating Wolfram Sang
2021-12-08 8:45 ` [PATCH 2/2] i2c: sh_mobile: " Wolfram Sang
2021-12-16 21:23 ` Wolfram Sang
2021-12-16 21:23 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbuuYVgSRJs1Bt6G@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).