* [PATCH] i2c: aspeed: Remove unused includes
@ 2021-12-07 14:17 Thierry Reding
2021-12-13 23:12 ` Joel Stanley
2021-12-16 21:27 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Thierry Reding @ 2021-12-07 14:17 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Rob Herring, linux-i2c, linux-aspeed
From: Thierry Reding <treding@nvidia.com>
No symbols from the linux/irqchip/chained_irq.h and linux/irqdomain.h
headers are used in the driver, so they can be removed.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/i2c/busses/i2c-aspeed.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 67e8b97c0c95..771e53d3d197 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -16,8 +16,6 @@
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/irq.h>
-#include <linux/irqchip/chained_irq.h>
-#include <linux/irqdomain.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of_address.h>
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: aspeed: Remove unused includes
2021-12-07 14:17 [PATCH] i2c: aspeed: Remove unused includes Thierry Reding
@ 2021-12-13 23:12 ` Joel Stanley
2021-12-16 21:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2021-12-13 23:12 UTC (permalink / raw)
To: Thierry Reding
Cc: Wolfram Sang, Rob Herring, open list:I2C SUBSYSTEM HOST DRIVERS,
linux-aspeed
On Mon, 13 Dec 2021 at 22:22, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> No symbols from the linux/irqchip/chained_irq.h and linux/irqdomain.h
> headers are used in the driver, so they can be removed.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Agreed, it looks like these were added in the initial commit and never used.
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/i2c/busses/i2c-aspeed.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 67e8b97c0c95..771e53d3d197 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -16,8 +16,6 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/irq.h>
> -#include <linux/irqchip/chained_irq.h>
> -#include <linux/irqdomain.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of_address.h>
> --
> 2.33.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: aspeed: Remove unused includes
2021-12-07 14:17 [PATCH] i2c: aspeed: Remove unused includes Thierry Reding
2021-12-13 23:12 ` Joel Stanley
@ 2021-12-16 21:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-12-16 21:27 UTC (permalink / raw)
To: Thierry Reding; +Cc: Rob Herring, linux-i2c, linux-aspeed
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
On Tue, Dec 07, 2021 at 03:17:22PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> No symbols from the linux/irqchip/chained_irq.h and linux/irqdomain.h
> headers are used in the driver, so they can be removed.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-07 14:17 [PATCH] i2c: aspeed: Remove unused includes Thierry Reding
2021-12-13 23:12 ` Joel Stanley
2021-12-16 21:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).