From: Wolfram Sang <wsa@kernel.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+e417648b303855b91d8a@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] i2c: don't pass 0 nmsgs to i2c_transfer
Date: Thu, 30 Dec 2021 23:20:03 +0100 [thread overview]
Message-ID: <Yc4wkyr7QTs8ao5x@kunai> (raw)
In-Reply-To: <20211225182418.26839-1-paskripkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
> - if (rdwr_arg.nmsgs > I2C_RDWR_IOCTL_MAX_MSGS)
> + if (!rdwr_arg.nmsgs || rdwr_arg.nmsgs > I2C_RDWR_IOCTL_MAX_MSGS)
> return -EINVAL;
Shouldn't we check the msgs pointer as well while we are here? Like in
the non-compat IOCTL code:
443 if (!rdwr_arg.msgs || rdwr_arg.nmsgs == 0)
444 return -EINVAL;
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-30 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 14:28 [PATCH] i2c: don't pass 0 nmsgs to i2c_transfer Pavel Skripkin
2021-12-25 18:24 ` [PATCH v2] " Pavel Skripkin
2021-12-30 22:20 ` Wolfram Sang [this message]
2021-12-30 22:26 ` Pavel Skripkin
2021-12-30 22:47 ` [PATCH v3] i2c: validate user data in compat ioctl Pavel Skripkin
2021-12-31 13:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc4wkyr7QTs8ao5x@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+e417648b303855b91d8a@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox