From: Wolfram Sang <wsa@kernel.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+e417648b303855b91d8a@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] i2c: validate user data in compat ioctl
Date: Fri, 31 Dec 2021 14:31:52 +0100 [thread overview]
Message-ID: <Yc8GSBr46QHEYcuI@kunai> (raw)
In-Reply-To: <20211230224750.15380-1-paskripkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Fri, Dec 31, 2021 at 01:47:50AM +0300, Pavel Skripkin wrote:
> Wrong user data may cause warning in i2c_transfer(), ex: zero msgs.
> Userspace should not be able to trigger warnings, so this patch adds
> validation checks for user data in compact ioctl to prevent reported
> warnings
>
> Reported-and-tested-by: syzbot+e417648b303855b91d8a@syzkaller.appspotmail.com
> Fixes: 7d5cb45655f2 ("i2c compat ioctls: move to ->compat_ioctl()")
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-31 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 14:28 [PATCH] i2c: don't pass 0 nmsgs to i2c_transfer Pavel Skripkin
2021-12-25 18:24 ` [PATCH v2] " Pavel Skripkin
2021-12-30 22:20 ` Wolfram Sang
2021-12-30 22:26 ` Pavel Skripkin
2021-12-30 22:47 ` [PATCH v3] i2c: validate user data in compat ioctl Pavel Skripkin
2021-12-31 13:31 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc8GSBr46QHEYcuI@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+e417648b303855b91d8a@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).