From: Wolfram Sang <wsa@kernel.org>
To: Sui Chen <suichen@google.com>
Cc: linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-i2c@vger.kernel.org, joel@jms.id.au, andrew@aj.id.au,
tali.perry1@gmail.com, benjaminfair@google.com,
krellan@google.com, joe@perches.com
Subject: Re: [RFC Patch v2 0/3] I2C statistics as sysfs attributes
Date: Mon, 3 Jan 2022 10:44:19 +0100 [thread overview]
Message-ID: <YdLFc/sJDf8rrPQ6@ninjato> (raw)
In-Reply-To: <CAJOps0u=seskB-YGvLBsHantJohkEX7do-mt7YSZ6zChQMQxbg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
> - Because we're targeting at-scale monitoring of fleets of machines
> in large numbers with identical hardware configuration, the
> I2C counters (including NACK) can be used for apples-to-apples
> comparison, for detecting anomaly, etc., while this may not be
> applicable to a single machine.
Okay, I buy this argument. Let's work on this during the next cycle.
From a glimpse, we need some refactoring, like moving stuff away from
i2c-dev into the core and probably add a generic stats-struct which can
be attached to i2c_adapter. But I'll respond to that in more detail to
v3 when I have a better picture.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-01-03 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 2:37 [RFC Patch v2 0/3] I2C statistics as sysfs attributes Sui Chen
2021-12-03 2:37 ` [RFC Patch v2 1/3] i2c debug counters " Sui Chen
2021-12-03 2:50 ` Joe Perches
2021-12-03 5:35 ` Sui Chen
2021-12-03 5:54 ` Joe Perches
2021-12-03 2:37 ` [RFC Patch v2 2/3] i2c: npcm7xx: add tx_complete counter Sui Chen
2021-12-03 2:37 ` [RFC Patch v2 3/3] add npcm7xx debug counters as sysfs attributes Sui Chen
2021-12-03 16:37 ` [RFC Patch v2 0/3] I2C statistics " Wolfram Sang
2021-12-07 16:00 ` Sui Chen
2022-01-03 9:44 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdLFc/sJDf8rrPQ6@ninjato \
--to=wsa@kernel.org \
--cc=andrew@aj.id.au \
--cc=benjaminfair@google.com \
--cc=joe@perches.com \
--cc=joel@jms.id.au \
--cc=krellan@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=suichen@google.com \
--cc=tali.perry1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).