From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
linus.walleij@linaro.org, broonie@kernel.org
Cc: Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: i2c: qcom-cci: add description of a vbus-supply property
Date: Fri, 4 Feb 2022 10:05:47 -0800 [thread overview]
Message-ID: <Yf1q+wlXo2LAeZX+@ripper> (raw)
In-Reply-To: <20220203164629.1711958-3-vladimir.zapolskiy@linaro.org>
On Thu 03 Feb 08:46 PST 2022, Vladimir Zapolskiy wrote:
> Quite regularly I2C bus lines on QCOM CCI controller require an external
> pull-up to a regulator powered line, to be able to define all such
> cases an additional vbus-supply property of a bus subnode is wanted.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt
> index 924ad8c03464..9f5b321748f1 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt
> @@ -60,6 +60,11 @@ PROPERTIES:
> Definition: Desired I2C bus clock frequency in Hz, defaults to 100
> kHz if omitted.
>
> +- vbus-supply:
I don't think "vbus" is an appropriate name for his. Perhaps "vddio" or
something like that would be better.
But there's a bigger question here, this is not a supply for the
i2c master, it's simply a supply for pulling up the bus. So it's not
entirely correct to specify it as a supply for the CCI node (which is
also the reason why the name isn't obvious).
Typically we don't don't mention the bus-supply because it happens to be
pulled up either by io-supply for the block, or by some always-on
regulator in the system.
Looping in Linus and Mark in hope they have seen this need elsewhere.
Regards,
Bjorn
> + Usage: optional
> + Value type: phandle
> + Definition: Regulator that provides power to SCL/SDA lines
> +
> Example:
>
> cci@a0c000 {
> --
> 2.33.0
>
next prev parent reply other threads:[~2022-02-04 18:05 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 16:46 [PATCH 0/9] i2c: qcom-cci: fixes and updates Vladimir Zapolskiy
2022-02-03 16:46 ` [PATCH 1/9] dt-bindings: i2c: qcom-cci: add QCOM SM8450 compatible Vladimir Zapolskiy
2022-02-04 11:04 ` Robert Foss
2022-02-11 14:12 ` Rob Herring
2022-02-18 9:02 ` Wolfram Sang
2022-02-03 16:46 ` [PATCH 2/9] dt-bindings: i2c: qcom-cci: add description of a vbus-supply property Vladimir Zapolskiy
2022-02-04 11:06 ` Robert Foss
2022-02-04 18:05 ` Bjorn Andersson [this message]
2022-02-04 18:42 ` Mark Brown
2022-02-04 19:02 ` Bjorn Andersson
2022-02-04 19:32 ` Mark Brown
2022-02-07 14:08 ` Vladimir Zapolskiy
2022-02-07 14:39 ` Mark Brown
2022-02-07 18:31 ` Vladimir Zapolskiy
2022-02-08 12:55 ` Mark Brown
2022-02-10 15:33 ` Dmitry Baryshkov
2022-02-10 15:44 ` Mark Brown
2022-02-10 17:32 ` Dmitry Baryshkov
2022-02-10 17:36 ` Mark Brown
2022-02-10 18:21 ` Dmitry Baryshkov
2022-02-10 18:26 ` Mark Brown
2022-02-10 19:02 ` Dmitry Baryshkov
2022-02-03 16:47 ` [PATCH 3/9] i2c: qcom-cci: don't delete an unregistered adapter Vladimir Zapolskiy
2022-02-04 10:05 ` Robert Foss
2022-02-04 18:08 ` Bjorn Andersson
2022-02-11 17:45 ` Wolfram Sang
2022-02-11 17:43 ` Wolfram Sang
2022-02-03 16:47 ` [PATCH 4/9] i2c: qcom-cci: don't put a device tree node before i2c_add_adapter() Vladimir Zapolskiy
2022-02-04 10:17 ` Robert Foss
2022-02-04 18:11 ` Bjorn Andersson
2022-02-11 17:44 ` Wolfram Sang
2022-02-03 16:47 ` [PATCH 5/9] i2c: qcom-cci: initialize CCI controller after registration of adapters Vladimir Zapolskiy
2022-02-03 17:29 ` Loic Poulain
2022-02-03 18:45 ` Vladimir Zapolskiy
2022-02-04 11:18 ` Loic Poulain
2022-02-04 18:31 ` Bjorn Andersson
2022-02-03 16:47 ` [PATCH 6/9] i2c: qcom-cci: simplify probe by removing one loop over busses Vladimir Zapolskiy
2022-02-04 10:20 ` Robert Foss
2022-02-03 16:47 ` [PATCH 7/9] i2c: qcom-cci: simplify access to bus data structure Vladimir Zapolskiy
2022-02-04 10:21 ` Robert Foss
2022-02-03 16:47 ` [PATCH 8/9] i2c: qcom-cci: add support of optional vbus-supply regulators Vladimir Zapolskiy
2022-02-04 11:03 ` Robert Foss
2022-02-04 11:41 ` Loic Poulain
2022-02-04 18:28 ` Bjorn Andersson
2022-02-10 15:37 ` Dmitry Baryshkov
2022-02-04 18:21 ` Bjorn Andersson
2022-02-03 16:47 ` [PATCH 9/9] i2c: qcom-cci: add sm8450 compatible Vladimir Zapolskiy
2022-02-04 11:03 ` Robert Foss
2022-02-18 9:02 ` Wolfram Sang
2022-02-11 17:49 ` [PATCH 0/9] i2c: qcom-cci: fixes and updates Wolfram Sang
2022-02-11 19:46 ` Vladimir Zapolskiy
2022-02-11 20:43 ` Wolfram Sang
2022-02-17 19:57 ` Wolfram Sang
2022-02-17 21:47 ` Vladimir Zapolskiy
2022-02-18 9:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf1q+wlXo2LAeZX+@ripper \
--to=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).