From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC2CC433F5 for ; Fri, 4 Feb 2022 18:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238825AbiBDSFt (ORCPT ); Fri, 4 Feb 2022 13:05:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377361AbiBDSFd (ORCPT ); Fri, 4 Feb 2022 13:05:33 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F29F0C061741 for ; Fri, 4 Feb 2022 10:05:32 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id i5so9468364oih.1 for ; Fri, 04 Feb 2022 10:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FjF+sGZpg2iaH76PumvDp14W7fNNxKuPMZR+Us0rVMQ=; b=WDWuvGT/OxA9GID0EgK9YDidQPh+HAa1en+YRr+jT4ZUb4X+eK3H8R6beO+FEvnyDG BZSlJT5PvdgA1sBVwVVVMTQFtMesxbeA9ZwEY//5gfvsSRzU4LZNMFcRnunjU7KSfjcZ okhZlE/GB/zmFuVhvn13M8n5tp8aIG4cwM6rTtTKLGfz+0zyQ3GmM814MUXEv9FgBUhD dWY+Fk4FpY3WU2Qi+JuDc2d2fC71MzEM5cXKgW7RapBc+IXMRjbtd+3uYN9ThXNgYvln HEeM7H/wbzGuKzDXOiKGAgXcNQ2U8NDGW/x6HhrTlnLNiQRLZj/hP+shOOrCFwDFj3L/ j5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FjF+sGZpg2iaH76PumvDp14W7fNNxKuPMZR+Us0rVMQ=; b=j/Q6K7cbiLTNy/a+CqW3qzGU/OL80ewf/TVsQg57pSc3M73GKrqARa2vSgsY+dXnty z7sDedeavJxLvzUI//u/TgKnhJZfAEIy99bMw51/4w2cm1JcpA1oPKz6AThJokkE0+2E Vmc4cLmukxO3/UB1Y/MnUZpWPS859d7EKnPHve+vgktfGUD1EEuJdhHtN5D7aB17Py9k b9rvUVXgDzWcdcgr6sgUCBGT1Rc7n3BC1YWXlXwevfEEG7dJTRxYG5XTVAGiNE75OVd8 J8epb8ixy/N9xV2XymGYge0S4qEuPvLlL249+MAgl1eYu+9jvEuZVxDtEj4kdCu4CIZs hHEw== X-Gm-Message-State: AOAM533Dx97xbVCJWrtlYEb7U0en1gc0Nhv8NHmMpJ8oPdvAcvN6jqTv ukHLZzuZtPNMqt6QSwQfgDWWRw== X-Google-Smtp-Source: ABdhPJylpcEz5omTCtvVVTdyfF1+oj/R9wH56W4rthEOGLG4g7VSkPI6Ojv1x35a8V+C7gXtZf9Ksw== X-Received: by 2002:a05:6808:ecf:: with SMTP id q15mr1881768oiv.130.1643997932289; Fri, 04 Feb 2022 10:05:32 -0800 (PST) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id a15sm1114445oil.13.2022.02.04.10.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 10:05:31 -0800 (PST) Date: Fri, 4 Feb 2022 10:05:47 -0800 From: Bjorn Andersson To: Vladimir Zapolskiy , linus.walleij@linaro.org, broonie@kernel.org Cc: Loic Poulain , Robert Foss , Rob Herring , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/9] dt-bindings: i2c: qcom-cci: add description of a vbus-supply property Message-ID: References: <20220203164629.1711958-1-vladimir.zapolskiy@linaro.org> <20220203164629.1711958-3-vladimir.zapolskiy@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203164629.1711958-3-vladimir.zapolskiy@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu 03 Feb 08:46 PST 2022, Vladimir Zapolskiy wrote: > Quite regularly I2C bus lines on QCOM CCI controller require an external > pull-up to a regulator powered line, to be able to define all such > cases an additional vbus-supply property of a bus subnode is wanted. > > Signed-off-by: Vladimir Zapolskiy > --- > Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt > index 924ad8c03464..9f5b321748f1 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-qcom-cci.txt > @@ -60,6 +60,11 @@ PROPERTIES: > Definition: Desired I2C bus clock frequency in Hz, defaults to 100 > kHz if omitted. > > +- vbus-supply: I don't think "vbus" is an appropriate name for his. Perhaps "vddio" or something like that would be better. But there's a bigger question here, this is not a supply for the i2c master, it's simply a supply for pulling up the bus. So it's not entirely correct to specify it as a supply for the CCI node (which is also the reason why the name isn't obvious). Typically we don't don't mention the bus-supply because it happens to be pulled up either by io-supply for the block, or by some always-on regulator in the system. Looping in Linus and Mark in hope they have seen this need elsewhere. Regards, Bjorn > + Usage: optional > + Value type: phandle > + Definition: Regulator that provides power to SCL/SDA lines > + > Example: > > cci@a0c000 { > -- > 2.33.0 >