From: Wolfram Sang <wsa@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+0591ccf54ee05344e4eb@syzkaller.appspotmail.com
Subject: Re: [PATCH v1 1/1] i2c: robotfuzz-osif: Propagate parent device to I2C core
Date: Fri, 18 Feb 2022 15:22:19 +0100 [thread overview]
Message-ID: <Yg+rm+ZjuhT4zPWB@ninjato> (raw)
In-Reply-To: <20220204151726.8924-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
> + struct device *dev = &interface->dev;
This now creates a mixture of 'dev' and '&interface->dev'...
> + priv->adapter.dev.parent = dev;
I propose to use &interface->dev here in this patch and convert to dev
in a later patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-18 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 15:17 [PATCH v1 1/1] i2c: robotfuzz-osif: Propagate parent device to I2C core Andy Shevchenko
2022-02-18 14:22 ` Wolfram Sang [this message]
2022-02-20 10:57 ` Andy Shevchenko
2022-02-21 9:56 ` Johan Hovold
2022-02-21 18:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg+rm+ZjuhT4zPWB@ninjato \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=johan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+0591ccf54ee05344e4eb@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).