From: Wolfram Sang <wsa@kernel.org>
To: Matt Johnston <matt@codeconstruct.com.au>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
Zev Weiss <zev@bewilderbeest.net>
Subject: Re: [PATCH net-next v5 2/2] mctp i2c: MCTP I2C binding driver
Date: Thu, 17 Feb 2022 09:58:53 +0100 [thread overview]
Message-ID: <Yg4N1SYeCdSPDR+V@ninjato> (raw)
In-Reply-To: <eaee265147f14982c89d400f80e4482a029cdf98.camel@codeconstruct.com.au>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hi Matt,
> I'll tidy up the comments. A filled /* first line is part of the netdev
> style.
Interesting, I didn't know that.
> I think 'slave' might be a bit unclear - the driver's acting as an I2C master
> too.
Right. Yet, AFAIU only when sending responses to other nodes, or? It
does not drive this one remote device with address 0xNN but acts itself
as device 0xMM.
> It also is more baggage moving to inclusive naming. Maybe mctp-i2c-
> transport or mctp-i2c-interface would suit?
+1 for inclusive naming. I like the "interface" addition.
Oh, and one other question I have meanwhile: do you really need
"mctp_current_mux" as a device attribute or is it mere debug and could
go away when upstream?
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-17 8:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:36 [PATCH net-next v5 0/2] MCTP I2C driver Matt Johnston
2022-02-10 6:36 ` [PATCH net-next v5 1/2] dt-bindings: net: New binding mctp-i2c-controller Matt Johnston
2022-02-10 14:41 ` Rob Herring
2022-02-16 15:54 ` Wolfram Sang
2022-02-10 6:36 ` [PATCH net-next v5 2/2] mctp i2c: MCTP I2C binding driver Matt Johnston
2022-02-11 22:38 ` Jakub Kicinski
2022-02-15 4:22 ` Matt Johnston
2022-02-15 5:04 ` Jakub Kicinski
2022-02-15 10:01 ` Matt Johnston
2022-02-15 15:58 ` Jakub Kicinski
2022-02-16 16:15 ` Wolfram Sang
2022-02-17 7:39 ` Matt Johnston
2022-02-17 8:58 ` Wolfram Sang [this message]
2022-02-17 9:22 ` Matt Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg4N1SYeCdSPDR+V@ninjato \
--to=wsa@kernel.org \
--cc=davem@davemloft.net \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).