* [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration
@ 2022-01-09 12:34 Christophe JAILLET
2022-01-13 10:28 ` Shah, Nehal-bakulchandra
2022-02-07 14:44 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-01-09 12:34 UTC (permalink / raw)
To: Elie Morisse, Nehal Shah, Shyam Sundar S K
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-i2c
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
Simplify code and remove some dead code accordingly.
[1]: https://lkml.org/lkml/2021/6/7/398
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/i2c/busses/i2c-amd-mp2-pci.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-amd-mp2-pci.c
index adf0e8c1ec01..f57077a7448d 100644
--- a/drivers/i2c/busses/i2c-amd-mp2-pci.c
+++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c
@@ -308,11 +308,8 @@ static int amd_mp2_pci_init(struct amd_mp2_dev *privdata,
pci_set_master(pci_dev);
rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(64));
- if (rc) {
- rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32));
- if (rc)
- goto err_dma_mask;
- }
+ if (rc)
+ goto err_dma_mask;
/* Set up intx irq */
writel(0, privdata->mmio + AMD_P2C_MSG_INTEN);
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration
2022-01-09 12:34 [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration Christophe JAILLET
@ 2022-01-13 10:28 ` Shah, Nehal-bakulchandra
2022-02-07 14:44 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Shah, Nehal-bakulchandra @ 2022-01-13 10:28 UTC (permalink / raw)
To: Christophe JAILLET, Elie Morisse, Shyam Sundar S K
Cc: linux-kernel, kernel-janitors, linux-i2c
On 1/9/2022 6:04 PM, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lkml.org/lkml/2021/6/7/398
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/i2c/busses/i2c-amd-mp2-pci.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-amd-mp2-pci.c
> index adf0e8c1ec01..f57077a7448d 100644
> --- a/drivers/i2c/busses/i2c-amd-mp2-pci.c
> +++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c
> @@ -308,11 +308,8 @@ static int amd_mp2_pci_init(struct amd_mp2_dev *privdata,
> pci_set_master(pci_dev);
>
> rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(64));
> - if (rc) {
> - rc = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32));
> - if (rc)
> - goto err_dma_mask;
> - }
> + if (rc)
> + goto err_dma_mask;
>
> /* Set up intx irq */
> writel(0, privdata->mmio + AMD_P2C_MSG_INTEN);
>
Acked-by: Nehal Bakulchandra Shah<Nehal-bakulchandra.Shah@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration
2022-01-09 12:34 [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration Christophe JAILLET
2022-01-13 10:28 ` Shah, Nehal-bakulchandra
@ 2022-02-07 14:44 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2022-02-07 14:44 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Elie Morisse, Nehal Shah, Shyam Sundar S K, linux-kernel,
kernel-janitors, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Sun, Jan 09, 2022 at 01:34:18PM +0100, Christophe JAILLET wrote:
> As stated in [1], dma_set_mask() with a 64-bit mask never fails if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
>
>
> Simplify code and remove some dead code accordingly.
>
> [1]: https://lkml.org/lkml/2021/6/7/398
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-07 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-09 12:34 [PATCH] i2c: amd-mp2: Remove useless DMA-32 fallback configuration Christophe JAILLET
2022-01-13 10:28 ` Shah, Nehal-bakulchandra
2022-02-07 14:44 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).