From: Wolfram Sang <wsa@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/9] i2c: qcom-cci: don't delete an unregistered adapter
Date: Fri, 11 Feb 2022 18:43:45 +0100 [thread overview]
Message-ID: <YgagUVXvjF7/CmWl@kunai> (raw)
In-Reply-To: <20220203164700.1711985-1-vladimir.zapolskiy@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Thu, Feb 03, 2022 at 06:47:00PM +0200, Vladimir Zapolskiy wrote:
> If i2c_add_adapter() fails to add an I2C adapter found on QCOM CCI
> controller, on error path i2c_del_adapter() is still called.
>
> Fortunately there is a sanity check in the I2C core, so the only
> visible implication is a printed debug level message:
>
> i2c-core: attempting to delete unregistered adapter [Qualcomm-CCI]
>
> Nevertheless it would be reasonable to correct the probe error path.
>
> Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-11 17:43 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 16:46 [PATCH 0/9] i2c: qcom-cci: fixes and updates Vladimir Zapolskiy
2022-02-03 16:46 ` [PATCH 1/9] dt-bindings: i2c: qcom-cci: add QCOM SM8450 compatible Vladimir Zapolskiy
2022-02-04 11:04 ` Robert Foss
2022-02-11 14:12 ` Rob Herring
2022-02-18 9:02 ` Wolfram Sang
2022-02-03 16:46 ` [PATCH 2/9] dt-bindings: i2c: qcom-cci: add description of a vbus-supply property Vladimir Zapolskiy
2022-02-04 11:06 ` Robert Foss
2022-02-04 18:05 ` Bjorn Andersson
2022-02-04 18:42 ` Mark Brown
2022-02-04 19:02 ` Bjorn Andersson
2022-02-04 19:32 ` Mark Brown
2022-02-07 14:08 ` Vladimir Zapolskiy
2022-02-07 14:39 ` Mark Brown
2022-02-07 18:31 ` Vladimir Zapolskiy
2022-02-08 12:55 ` Mark Brown
2022-02-10 15:33 ` Dmitry Baryshkov
2022-02-10 15:44 ` Mark Brown
2022-02-10 17:32 ` Dmitry Baryshkov
2022-02-10 17:36 ` Mark Brown
2022-02-10 18:21 ` Dmitry Baryshkov
2022-02-10 18:26 ` Mark Brown
2022-02-10 19:02 ` Dmitry Baryshkov
2022-02-03 16:47 ` [PATCH 3/9] i2c: qcom-cci: don't delete an unregistered adapter Vladimir Zapolskiy
2022-02-04 10:05 ` Robert Foss
2022-02-04 18:08 ` Bjorn Andersson
2022-02-11 17:45 ` Wolfram Sang
2022-02-11 17:43 ` Wolfram Sang [this message]
2022-02-03 16:47 ` [PATCH 4/9] i2c: qcom-cci: don't put a device tree node before i2c_add_adapter() Vladimir Zapolskiy
2022-02-04 10:17 ` Robert Foss
2022-02-04 18:11 ` Bjorn Andersson
2022-02-11 17:44 ` Wolfram Sang
2022-02-03 16:47 ` [PATCH 5/9] i2c: qcom-cci: initialize CCI controller after registration of adapters Vladimir Zapolskiy
2022-02-03 17:29 ` Loic Poulain
2022-02-03 18:45 ` Vladimir Zapolskiy
2022-02-04 11:18 ` Loic Poulain
2022-02-04 18:31 ` Bjorn Andersson
2022-02-03 16:47 ` [PATCH 6/9] i2c: qcom-cci: simplify probe by removing one loop over busses Vladimir Zapolskiy
2022-02-04 10:20 ` Robert Foss
2022-02-03 16:47 ` [PATCH 7/9] i2c: qcom-cci: simplify access to bus data structure Vladimir Zapolskiy
2022-02-04 10:21 ` Robert Foss
2022-02-03 16:47 ` [PATCH 8/9] i2c: qcom-cci: add support of optional vbus-supply regulators Vladimir Zapolskiy
2022-02-04 11:03 ` Robert Foss
2022-02-04 11:41 ` Loic Poulain
2022-02-04 18:28 ` Bjorn Andersson
2022-02-10 15:37 ` Dmitry Baryshkov
2022-02-04 18:21 ` Bjorn Andersson
2022-02-03 16:47 ` [PATCH 9/9] i2c: qcom-cci: add sm8450 compatible Vladimir Zapolskiy
2022-02-04 11:03 ` Robert Foss
2022-02-18 9:02 ` Wolfram Sang
2022-02-11 17:49 ` [PATCH 0/9] i2c: qcom-cci: fixes and updates Wolfram Sang
2022-02-11 19:46 ` Vladimir Zapolskiy
2022-02-11 20:43 ` Wolfram Sang
2022-02-17 19:57 ` Wolfram Sang
2022-02-17 21:47 ` Vladimir Zapolskiy
2022-02-18 9:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgagUVXvjF7/CmWl@kunai \
--to=wsa@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=robert.foss@linaro.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).