Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items

Conor Dooley
2022-02-24T13:46:30Z

On 24/02/2022 13:34, Geert Uytterhoeven wrote:
> Hi Conor,
>
> On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote:
>> On 24/02/2022 12:58, Geert Uytterhoeven wrote:
>>> On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
>>>> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
>>>>> make dt_binding_check:
>>>>>
>>>>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>>>
>>>> Hey Geert,
>>>> I've run dt_binding_check locally but I dont get a warning, is there
>>>> something I am missing?
>>>
>>> Interesting. Are you using the latest dtschema?
>>> https://github.com/devicetree-org/dt-schema.git
>>
>> I was on v2021.12, but have now tried v2022.01 & master
>> (2022.2.dev1+gf677c85).
>>
>> Is there something other than running "make dt_binding_check" in a fresh
>> checkout that I need to do?
>
> You did update your installation after the fresh[1] checkout?
>
> $ cd dt-schema
> $ pip3 install -e .
>
> [1] What about "git pull"? ;-)
>

I went for the option of "pip3 install
git+https://github.com/devicetree-org/dt-schema.git@master"
If I alter check_dtschema_version to spit out the version, its as
expected. The checkout was of Linux not the dt-schema.

I have found the issue however, realised just before Rob pointed it out
that I missed yamllint when I reinstalled my OS recently.