Re: [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts

Andy Shevchenko
2022-03-03T10:37:59Z

On Thu, Mar 03, 2022 at 04:31:39PM +0800, Tyrone Ting wrote:
> From: Tali Perry <tali.perry1@gmail.com>
>
> In order to better handle spurious interrupts:
> 1. Disable incoming interrupts in master only mode.
> 2. Clear end of busy (EOB) after every interrupt.
> 3. Return correct status during interrupt.

This is bad commit message, it doesn't explain "why" you are doing these.

...

> + /*
> + * if irq is not one of the above, make sure EOB is disabled and all
> + * status bits are cleared.

This does not explain why you hide the spurious interrupt.

> + */
> + if (ret == IRQ_NONE) {
> + npcm_i2c_eob_int(bus, false);
> + npcm_i2c_clear_master_status(bus);
> + }
> +
> + return IRQ_HANDLED;

--
With Best Regards,
Andy Shevchenko