From: Wolfram Sang <wsa@kernel.org>
To: Ian Dannapel <Ian.Dannapel@iris-sensing.com>,
Oleksij Rempel <linux@rempel-privat.de>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: i2c-imx.c: Unnecessary delay slowing down i2c communication
Date: Thu, 3 Mar 2022 22:33:10 +0100 [thread overview]
Message-ID: <YiE0FnKL4+4RXEaY@shikoro> (raw)
In-Reply-To: <D783F898DE87F646B39A5F514F7A514C672F0E@ERDE.irisgmbh.local>
[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]
On Thu, Mar 03, 2022 at 03:19:00PM +0000, Ian Dannapel wrote:
> Hello I²C Driver Maintainers,
Adding the i2c-imx maintainer to CC.
>
> please excuse me if I am not following the right steps to report a question. I did not find consensus between all instructions that I read.
>
> We noted that on the IMX i2c driver, at the i2c_imx_start funtion, some sleep/delay was introduced without any apparent reason:
> Line 448 at: https://github.com/Freescale/linux-fslc/commit/3a5ee18d2a32bda6b9a1260136f6805848e3839d
> Line 528 at: https://github.com/Freescale/linux-fslc/commit/2b899f34e1db9adef8716d07e872a800dfa60790
> Line 200 at: https://github.com/Freescale/linux-fslc/commit/43309f3b521302bb66c4c9e66704dd3675e4d725
>
> This sleep causes a pretty big latency overhead on I²C writes and no IMX8MP document states the need of this delay on the controller. NXP Support also informed that this delay might not be needed.
> Some early tests with removing this delay completely showed a great reduction on the write latency and no problems with the communication.
>
> But since we want a stable and fast communication, I ask here again if someone knows the reason or the need for this delay when starting to communicate on the I2C bus.
>
> I appreciate any response and if further information is needed, I can gladly report it.
>
>
> Best regards,
> Ian Dannapel
> ian.dannapel@iris-sensing.com
> • • • • • • • • • • • • • • • • • • • • • • • • • •
> iris-GmbH
> infrared & intelligent sensors
> Schnellerstraße 1-5 | 12439 Berlin
> www.iris-sensing.com
>
>
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-03 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D783F898DE87F646B39A5F514F7A514C672EC8@ERDE.irisgmbh.local>
2022-03-03 15:19 ` i2c-imx.c: Unnecessary delay slowing down i2c communication Ian Dannapel
2022-03-03 21:33 ` Wolfram Sang [this message]
2022-03-04 13:20 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiE0FnKL4+4RXEaY@shikoro \
--to=wsa@kernel.org \
--cc=Ian.Dannapel@iris-sensing.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox