[PATCH] i2c: i801: Drop two outdated comments

[PATCH] i2c: i801: Drop two outdated comments

[Jean Delvare]

* Timeouts are reported even in interrupt mode since commit
  b3b8df97723d ("i2c: i801: Use wait_event_timeout to wait for
  interrupts") so drop the comment which claims this only happens in
  polled mode.
* xact does not include the PEC bit, as the driver does not support
  software PEC.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
Please correct me if I'm wrong.

 drivers/i2c/busses/i2c-i801.c |    5 -----
 1 file changed, 5 deletions(-)

--- linux-5.16.orig/drivers/i2c/busses/i2c-i801.c	2022-03-01 17:35:49.586064557 +0100
+++ linux-5.16/drivers/i2c/busses/i2c-i801.c	2022-03-03 17:27:30.265701684 +0100
@@ -364,9 +364,6 @@ static int i801_check_post(struct i801_p
 
 	/*
 	 * If the SMBus is still busy, we give up
-	 * Note: This timeout condition only happens when using polling
-	 * transactions.  For interrupt operation, NAK/timeout is indicated by
-	 * DEV_ERR.
 	 */
 	if (unlikely(status < 0)) {
 		dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
@@ -475,8 +472,6 @@ static int i801_transaction(struct i801_
 		return i801_check_post(priv, result ? priv->status : -ETIMEDOUT);
 	}
 
-	/* the current contents of SMBHSTCNT can be overwritten, since PEC,
-	 * SMBSCMD are passed in xact */
 	outb_p(xact | SMBHSTCNT_START, SMBHSTCNT(priv));
 
 	status = i801_wait_intr(priv);


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] i2c: i801: Drop two outdated comments

[Jarkko Nikula]

On 3/3/22 18:42, Jean Delvare wrote:
> * Timeouts are reported even in interrupt mode since commit
>    b3b8df97723d ("i2c: i801: Use wait_event_timeout to wait for
>    interrupts") so drop the comment which claims this only happens in
>    polled mode.
> * xact does not include the PEC bit, as the driver does not support
>    software PEC.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> ---
> Please correct me if I'm wrong.
> 
>   drivers/i2c/busses/i2c-i801.c |    5 -----
>   1 file changed, 5 deletions(-)
> 
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Re: [PATCH] i2c: i801: Drop two outdated comments

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Thu, Mar 03, 2022 at 05:42:56PM +0100, Jean Delvare wrote:
> * Timeouts are reported even in interrupt mode since commit
>   b3b8df97723d ("i2c: i801: Use wait_event_timeout to wait for
>   interrupts") so drop the comment which claims this only happens in
>   polled mode.
> * xact does not include the PEC bit, as the driver does not support
>   software PEC.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]